Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: .hgignore
Issue
29330389
:
Issue 2956 - Ensure the correct version of jsshell is present (Closed)
Patch Set: Make sure to close the urllib response object
Created Nov. 23, 2015, 1:15 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Use regexp to match version number and tidy things up
Patch Set 3: Base directory name on jsshell version, avoid checking which version the binary outputs
Patch Set 4: Make sure to close the urllib response object
Patch Set 5: Don't download jsshell twice!
Patch Set 6: Remove JSSHELL_VERSION variable
Right:
Patch Set 1: None
Patch Set 2: Use regexp to match version number and tidy things up
Patch Set 3: Base directory name on jsshell version, avoid checking which version the binary outputs
Patch Set 4: Make sure to close the urllib response object
Patch Set 5: Don't download jsshell twice!
Patch Set 6: Remove JSSHELL_VERSION variable
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
.gitignore
.hgignore
utils.py
View unified diff
|
Download patch
« no previous file with comments
|
« .gitignore
('k') |
utils.py »
('j') |
utils.py »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 ^mozilla/
1 ^mozilla/
2
^jsshell-.*/
2 ^jstest/
3 ^jstest/
3
4
4 \.pyc$
5 \.pyc$
OLD
NEW
« no previous file with comments
|
« .gitignore
('k') |
utils.py »
('j') |
utils.py »
('J')
Edit Message
Issue 29330389: Issue 2956 - Ensure the correct version of jsshell is present (Closed)
Created Nov. 18, 2015, 2:56 p.m. by kzar
Modified Nov. 24, 2015, 10:33 a.m.
Reviewers: Sebastian Noack, Wladimir Palant
Base URL:
Comments: 19
+ 1 drafts
This is Rietveld