Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: adblockplus.gyp

Issue 29330403: Issue #1467, #3397 - Rewrite the map from threads to tabs (Closed)
Left Patch Set: Created Nov. 22, 2015, 8:17 p.m.
Right Patch Set: add comment; new function body Created July 17, 2016, 4:01 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | src/plugin/Instances.h » ('j') | src/plugin/Instances.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 { 1 {
2 'includes': [ 2 'includes': [
3 'defaults.gypi', 3 'defaults.gypi',
4 'common/common.gypi', 4 'common/common.gypi',
5 ], 5 ],
6 6
7 'variables': { 7 'variables': {
8 'build_type%': 'devbuild', 8 'build_type%': 'devbuild',
9 'build_version%': '', 9 'build_version%': '',
10 }, 10 },
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 'src/shared/Communication.cpp', 45 'src/shared/Communication.cpp',
46 'src/shared/Communication.h', 46 'src/shared/Communication.h',
47 'src/shared/CriticalSection.h', 47 'src/shared/CriticalSection.h',
48 'src/shared/Dictionary.cpp', 48 'src/shared/Dictionary.cpp',
49 'src/shared/Dictionary.h', 49 'src/shared/Dictionary.h',
50 'src/shared/Utils.cpp', 50 'src/shared/Utils.cpp',
51 'src/shared/Utils.h', 51 'src/shared/Utils.h',
52 'src/shared/Version.h', 52 'src/shared/Version.h',
53 'src/shared/MsHTMLUtils.cpp', 53 'src/shared/MsHTMLUtils.cpp',
54 'src/shared/MsHTMLUtils.h', 54 'src/shared/MsHTMLUtils.h',
55 ] 55 ],
56 'include_dirs': [
57 '$(ADBLOCKPLUS_ATL)/include',
58 ],
56 }, 59 },
57 60
58 { 61 {
59 'target_name': 'AdblockPlusEngine', 62 'target_name': 'AdblockPlusEngine',
60 'type': 'executable', 63 'type': 'executable',
61 'dependencies': [ 64 'dependencies': [
62 'shared', 65 'shared',
63 'libadblockplus/libadblockplus.gyp:libadblockplus', 66 'libadblockplus/libadblockplus.gyp:libadblockplus',
64 ], 67 ],
65 'sources': [ 68 'sources': [
66 'src/engine/Main.cpp', 69 'src/engine/Main.cpp',
67 'src/engine/NotificationWindow.cpp', 70 'src/engine/NotificationWindow.cpp',
68 'src/engine/NotificationWindow.h', 71 'src/engine/NotificationWindow.h',
69 'src/engine/Debug.cpp', 72 'src/engine/Debug.cpp',
70 'src/engine/UpdateInstallDialog.cpp', 73 'src/engine/UpdateInstallDialog.cpp',
71 'src/engine/Updater.cpp', 74 'src/engine/Updater.cpp',
72 'src/engine/engine.rc', 75 'src/engine/engine.rc',
73 ], 76 ],
77 'include_dirs': [
78 '$(ADBLOCKPLUS_ATL)/include',
79 ],
74 'libraries': [ 80 'libraries': [
75 '-ladvapi32', 81 '-ladvapi32',
76 '-lole32', 82 '-lole32',
77 '-luser32', 83 '-luser32',
78 '-lshell32', 84 '-lshell32',
79 '-lshlwapi', 85 '-lshlwapi',
80 ], 86 ],
81 'msbuild_toolset': 'v110_xp', 87 'msbuild_toolset': 'v110_xp',
82 'msvs_settings': { 88 'msvs_settings': {
83 'VCLinkerTool': { 89 'VCLinkerTool': {
84 'DelayLoadDLLs': ['Shell32.dll'], 90 'DelayLoadDLLs': ['Shell32.dll'],
91 'conditions': [[
92 'target_arch=="ia32"', {
93 'AdditionalLibraryDirectories': [
94 '$(ADBLOCKPLUS_ATL)/lib',
95 ],
96 }, {
97 'AdditionalLibraryDirectories': [
98 '$(ADBLOCKPLUS_ATL)/lib/amd64',
99 ],
100 }
101 ]],
85 }, 102 },
86 }, 103 },
87 }, 104 },
88 105
89 { 106 {
90 'target_name': 'AdblockPlus', 107 'target_name': 'AdblockPlus',
91 'type': 'shared_library', 108 'type': 'shared_library',
92 'dependencies': [ 109 'dependencies': [
93 'shared', 110 'shared',
94 'libadblockplus/libadblockplus.gyp:libadblockplus', 111 'libadblockplus/libadblockplus.gyp:libadblockplus',
95 ], 112 ],
96 'sources': [ 113 'sources': [
97 'src/plugin/AdblockPlus.def', 114 'src/plugin/AdblockPlus.def',
98 'src/plugin/AdblockPlus.idl', 115 'src/plugin/AdblockPlus.idl',
99 'src/plugin/AdblockPlus.rc', 116 'src/plugin/AdblockPlus.rc',
100 'src/plugin/AdblockPlus.rgs', 117 'src/plugin/AdblockPlus.rgs',
101 'src/plugin/AdblockPlusClient.cpp', 118 'src/plugin/AdblockPlusClient.cpp',
102 'src/plugin/AdblockPlusClient.h', 119 'src/plugin/AdblockPlusClient.h',
103 'src/plugin/AdblockPlusDomTraverser.cpp', 120 'src/plugin/AdblockPlusDomTraverser.cpp',
104 'src/plugin/AdblockPlusDomTraverser.h', 121 'src/plugin/AdblockPlusDomTraverser.h',
105 'src/plugin/AdblockPlusGuids.h', 122 'src/plugin/AdblockPlusGuids.h',
106 'src/plugin/ATL_Deprecate.cpp', 123 'src/plugin/ATL_Deprecate.cpp',
107 'src/plugin/ATL_Deprecate.h', 124 'src/plugin/ATL_Deprecate.h',
108 'src/plugin/Config.h', 125 'src/plugin/Config.h',
109 'src/plugin/Console.h',
110 'src/plugin/Instances.h', 126 'src/plugin/Instances.h',
111 'src/plugin/NotificationMessage.cpp', 127 'src/plugin/NotificationMessage.cpp',
112 'src/plugin/NotificationMessage.h', 128 'src/plugin/NotificationMessage.h',
113 'src/plugin/Plugin.cpp', 129 'src/plugin/Plugin.cpp',
114 'src/plugin/Plugin.h', 130 'src/plugin/Plugin.h',
115 'src/plugin/PluginClass.cpp', 131 'src/plugin/PluginClass.cpp',
116 'src/plugin/PluginClass.h', 132 'src/plugin/PluginClass.h',
117 'src/plugin/PluginClientBase.cpp', 133 'src/plugin/PluginClientBase.cpp',
118 'src/plugin/PluginClientBase.h', 134 'src/plugin/PluginClientBase.h',
119 'src/plugin/PluginClientFactory.cpp', 135 'src/plugin/PluginClientFactory.cpp',
120 'src/plugin/PluginClientFactory.h', 136 'src/plugin/PluginClientFactory.h',
121 'src/plugin/PluginDebug.cpp', 137 'src/plugin/PluginDebug.cpp',
122 'src/plugin/PluginDebug.h', 138 'src/plugin/PluginDebug.h',
123 'src/plugin/PluginDomTraverserBase.h', 139 'src/plugin/PluginDomTraverserBase.h',
124 'src/plugin/PluginErrorCodes.h', 140 'src/plugin/PluginErrorCodes.h',
125 'src/plugin/PluginFilter.cpp', 141 'src/plugin/PluginFilter.cpp',
126 'src/plugin/PluginFilter.h', 142 'src/plugin/PluginFilter.h',
127 'src/plugin/PluginMimeFilterClient.cpp', 143 'src/plugin/PluginMimeFilterClient.cpp',
128 'src/plugin/PluginMimeFilterClient.h', 144 'src/plugin/PluginMimeFilterClient.h',
129 'src/plugin/PluginMutex.cpp', 145 'src/plugin/PluginMutex.cpp',
130 'src/plugin/PluginMutex.h', 146 'src/plugin/PluginMutex.h',
131 'src/plugin/PluginPassthroughObject.h',
132 'src/plugin/PluginSettings.cpp', 147 'src/plugin/PluginSettings.cpp',
133 'src/plugin/PluginSettings.h', 148 'src/plugin/PluginSettings.h',
134 'src/plugin/PluginStdAfx.cpp', 149 'src/plugin/PluginStdAfx.cpp',
135 'src/plugin/PluginStdAfx.h', 150 'src/plugin/PluginStdAfx.h',
136 'src/plugin/PluginSystem.cpp', 151 'src/plugin/PluginSystem.cpp',
137 'src/plugin/PluginSystem.h', 152 'src/plugin/PluginSystem.h',
138 'src/plugin/PluginTabBase.cpp', 153 'src/plugin/PluginTabBase.cpp',
139 'src/plugin/PluginTabBase.h', 154 'src/plugin/PluginTabBase.h',
140 'src/plugin/PluginUserSettings.cpp', 155 'src/plugin/PluginUserSettings.cpp',
141 'src/plugin/PluginUserSettings.h', 156 'src/plugin/PluginUserSettings.h',
142 'src/plugin/PluginUtil.cpp', 157 'src/plugin/PluginUtil.cpp',
143 'src/plugin/PluginUtil.h', 158 'src/plugin/PluginUtil.h',
144 'src/plugin/PluginWbPassThrough.cpp', 159 'src/plugin/PluginWbPassThrough.cpp',
145 'src/plugin/PluginWbPassThrough.h', 160 'src/plugin/PluginWbPassThrough.h',
146 'src/plugin/ProtocolCF.h',
147 'src/plugin/ProtocolCF.inl',
148 'src/plugin/ProtocolImpl.h',
149 'src/plugin/ProtocolImpl.inl',
150 'src/plugin/Resource.h', 161 'src/plugin/Resource.h',
151 'src/plugin/SinkPolicy.h', 162 'src/plugin/passthroughapp/PassthroughObject.h',
152 'src/plugin/SinkPolicy.inl', 163 'src/plugin/passthroughapp/ProtocolCF.h',
153 ], 164 'src/plugin/passthroughapp/ProtocolCF.inl',
154 'include_dirs': [ 165 'src/plugin/passthroughapp/ProtocolImpl.h',
155 '$(WindowsSDK_IncludePath)', 166 'src/plugin/passthroughapp/ProtocolImpl.inl',
156 '$(VCInstallDir)atlmfc/include', 167 'src/plugin/passthroughapp/SinkPolicy.h',
157 '$(WINDDKDIR)/inc/atl71', 168 'src/plugin/passthroughapp/SinkPolicy.inl',
169 ],
170 'include_dirs': [
171 '$(ADBLOCKPLUS_ATL)/include',
158 ], 172 ],
159 # See "Adding Visual Style Support to an Extension, Plug-in, MMC Snap-in or a DLL 173 # See "Adding Visual Style Support to an Extension, Plug-in, MMC Snap-in or a DLL
160 # That Is Brought into a Process" on the link here: 174 # That Is Brought into a Process" on the link here:
161 # http://msdn.microsoft.com/en-us/library/windows/desktop/bb773175%28v=vs.85 %29.aspx#using_manifests 175 # http://msdn.microsoft.com/en-us/library/windows/desktop/bb773175%28v=vs.85 %29.aspx#using_manifests
162 'defines': ['ISOLATION_AWARE_ENABLED'], 176 'defines': ['ISOLATION_AWARE_ENABLED'],
163 'libraries': [ 177 'libraries': [
164 '-lwinhttp', 178 '-lwinhttp',
165 '-lshell32', 179 '-lshell32',
166 '-lComctl32', 180 '-lComctl32',
167 '-lGdi32', 181 '-lGdi32',
168 ], 182 ],
169 'configurations': {
170 # 'libraries' is not allowed under 'configurations' :-(
171 'Debug': {
172 'msvs_settings': {
173 'VCLinkerTool': {
174 'AdditionalDependencies': ['atlsd.lib'],
175 },
176 },
177 },
178 'Release': {
179 'msvs_settings': {
180 'VCLinkerTool': {
181 'AdditionalDependencies': ['atls.lib'],
182 },
183 },
184 },
185 },
186 'msvs_settings': { 183 'msvs_settings': {
187 'VCLinkerTool': { 184 'VCLinkerTool': {
188 'conditions': [[ 185 'conditions': [[
189 'target_arch=="ia32"', { 186 'target_arch=="ia32"', {
190 'AdditionalLibraryDirectories': [ 187 'AdditionalLibraryDirectories': [
191 '$(VCInstallDir)atlmfc/lib', 188 '$(ADBLOCKPLUS_ATL)/lib',
192 '$(WindowsSDK_LibraryPath_x86)',
193 '$(WINDDKDIR)/lib/ATL/i386',
194 ], 189 ],
195 }, { 190 }, {
196 'AdditionalLibraryDirectories': [ 191 'AdditionalLibraryDirectories': [
197 '$(VCInstallDir)atlmfc/lib/amd64', 192 '$(ADBLOCKPLUS_ATL)/lib/amd64',
198 '$(WindowsSDK_LibraryPath_x64)',
199 '$(WINDDKDIR)/lib/ATL/amd64',
200 ], 193 ],
201 } 194 }
202 ]], 195 ]],
203 'DelayLoadDLLs': ['Shell32.dll'], 196 'DelayLoadDLLs': ['Shell32.dll'],
204 }, 197 },
205 }, 198 },
206 }, 199 },
207 200
208 { 201 {
209 'target_name': 'tests', 202 'target_name': 'tests',
210 'type': 'executable', 203 'type': 'executable',
211 'dependencies': [ 204 'dependencies': [
212 'shared', 205 'shared',
213 'libadblockplus/third_party/googletest.gyp:googletest_main', 206 'libadblockplus/third_party/googletest.gyp:googletest_main',
214 ], 207 ],
215 'sources': [ 208 'sources': [
216 'test/CommunicationTest.cpp', 209 'test/CommunicationTest.cpp',
217 'test/DictionaryTest.cpp', 210 'test/DictionaryTest.cpp',
218 'test/UtilTest.cpp', 211 'test/UtilTest.cpp',
219 'test/UtilGetQueryStringTest.cpp', 212 'test/UtilGetQueryStringTest.cpp',
220 'test/UtilGetSchemeAndHierarchicalPartTest.cpp', 213 'test/UtilGetSchemeAndHierarchicalPartTest.cpp',
221 ], 214 ],
222 'defines': ['WINVER=0x0501'], 215 'defines': ['WINVER=0x0501'],
223 'link_settings': { 216 'link_settings': {
224 'libraries': ['-ladvapi32', '-lshell32', '-lole32'], 217 'libraries': ['-ladvapi32', '-lshell32', '-lole32', '-loleaut32'],
225 }, 218 },
226 'msvs_settings': { 219 'msvs_settings': {
227 'VCLinkerTool': { 220 'VCLinkerTool': {
228 'SubSystem': '1', # Console 221 'SubSystem': '1', # Console
229 'EntryPointSymbol': 'mainCRTStartup', 222 'EntryPointSymbol': 'mainCRTStartup',
230 }, 223 },
231 }, 224 },
232 }, 225 },
233 226
234 { 227 {
235 'target_name': 'tests_plugin', 228 'target_name': 'tests_plugin',
236 'type': 'executable', 229 'type': 'executable',
237 'dependencies': [ 230 'dependencies': [
238 'shared', 231 'shared',
239 'libadblockplus/libadblockplus.gyp:libadblockplus', 232 'libadblockplus/libadblockplus.gyp:libadblockplus',
240 'libadblockplus/third_party/googletest.gyp:googletest_main', 233 'libadblockplus/third_party/googletest.gyp:googletest_main',
241 ], 234 ],
242 'sources': [ 235 'sources': [
236 'src/plugin/PluginDebug.cpp',
237 'test/plugin/DebugTest.cpp',
243 'src/plugin/Instances.h', 238 'src/plugin/Instances.h',
244 'test/plugin/InstancesTest.cpp', 239 'test/plugin/InstancesTest.cpp',
245 'src/plugin/PluginUserSettings.cpp', 240 'src/plugin/PluginUserSettings.cpp',
246 'src/plugin/PluginUserSettings.h', 241 'src/plugin/PluginUserSettings.h',
247 'test/plugin/UserSettingsTest.cpp', 242 'test/plugin/UserSettingsTest.cpp',
248 'src/plugin/PluginUtil.h', 243 'src/plugin/PluginUtil.h',
249 'test/plugin/UtilTest.cpp', 244 'test/plugin/UtilTest.cpp',
250 # 245 #
251 # required only for linking 246 # required only for linking
252 # 247 #
253 'src/plugin/AdblockPlusClient.cpp', 248 'src/plugin/AdblockPlusClient.cpp',
254 'src/plugin/AdblockPlusDomTraverser.cpp', 249 'src/plugin/AdblockPlusDomTraverser.cpp',
255 'src/plugin/ATL_Deprecate.cpp', 250 'src/plugin/ATL_Deprecate.cpp',
256 'src/plugin/NotificationMessage.cpp', 251 'src/plugin/NotificationMessage.cpp',
257 'src/plugin/Plugin.cpp', 252 'src/plugin/Plugin.cpp',
258 'src/plugin/PluginClientBase.cpp', 253 'src/plugin/PluginClientBase.cpp',
259 'src/plugin/PluginClientFactory.cpp', 254 'src/plugin/PluginClientFactory.cpp',
260 'src/plugin/PluginClass.cpp', 255 'src/plugin/PluginClass.cpp',
261 'src/plugin/PluginDebug.cpp',
262 'src/plugin/PluginFilter.cpp', 256 'src/plugin/PluginFilter.cpp',
263 'src/plugin/PluginMimeFilterClient.cpp', 257 'src/plugin/PluginMimeFilterClient.cpp',
264 'src/plugin/PluginMutex.cpp', 258 'src/plugin/PluginMutex.cpp',
265 'src/plugin/PluginSettings.cpp', 259 'src/plugin/PluginSettings.cpp',
266 'src/plugin/PluginSystem.cpp', 260 'src/plugin/PluginSystem.cpp',
267 'src/plugin/PluginTabBase.cpp', 261 'src/plugin/PluginTabBase.cpp',
268 'src/plugin/PluginUtil.cpp', 262 'src/plugin/PluginUtil.cpp',
269 'src/plugin/PluginWbPassthrough.cpp', 263 'src/plugin/PluginWbPassthrough.cpp',
270 ], 264 ],
271 'include_dirs': [ 265 'include_dirs': [
272 '$(WINDDKDIR)/inc/atl71', 266 '$(ADBLOCKPLUS_ATL)/include',
273 ], 267 ],
274 'defines': [ 268 'defines': [
275 'WINVER=0x0501', 269 'WINVER=0x0501',
276 'PRODUCT_ADBLOCKPLUS' 270 'PRODUCT_ADBLOCKPLUS'
277 ], 271 ],
278 'link_settings': { 272 'link_settings': {
279 'libraries': ['-ladvapi32', '-lshell32', '-lole32', '-lComctl32', '-lGdi32 '], 273 'libraries': ['-ladvapi32', '-lshell32', '-lole32', '-lComctl32', '-lGdi32 '],
280 }, 274 },
281 'msvs_settings': { 275 'msvs_settings': {
282 'VCLinkerTool': { 276 'VCLinkerTool': {
283 'SubSystem': '1', # Console 277 'SubSystem': '1', # Console
284 'EntryPointSymbol': 'mainCRTStartup', 278 'EntryPointSymbol': 'mainCRTStartup',
285 'conditions': [[ 279 'conditions': [[
286 'target_arch=="ia32"', { 280 'target_arch=="ia32"', {
287 'AdditionalLibraryDirectories': [ 281 'AdditionalLibraryDirectories': [
288 '$(VCInstallDir)atlmfc/lib', 282 '$(ADBLOCKPLUS_ATL)/lib',
289 '$(WindowsSDK_LibraryPath_x86)',
290 '$(WINDDKDIR)/lib/ATL/i386',
291 ], 283 ],
292 }, { 284 }, {
293 'AdditionalLibraryDirectories': [ 285 'AdditionalLibraryDirectories': [
294 '$(VCInstallDir)atlmfc/lib/amd64', 286 '$(ADBLOCKPLUS_ATL)/lib/amd64',
295 '$(WindowsSDK_LibraryPath_x64)',
296 '$(WINDDKDIR)/lib/ATL/amd64',
297 ], 287 ],
298 } 288 }
299 ]], 289 ]],
300 }, 290 },
301 }, 291 },
302 'configurations': {
303 # 'libraries' is not allowed under 'configurations' :-(
304 'Debug': {
305 'msvs_settings': {
306 'VCLinkerTool': {
307 'AdditionalDependencies': ['atlsd.lib'],
308 },
309 },
310 },
311 'Release': {
312 'msvs_settings': {
313 'VCLinkerTool': {
314 'AdditionalDependencies': ['atls.lib'],
315 },
316 },
317 },
318 },
319 }] 292 }]
320 } 293 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld