src/plugin/PluginClass.h - Issue 29330403: Issue #1467, #3397 - Rewrite the map from threads to tabs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: src/plugin/PluginClass.h

Issue 29330403: Issue #1467, #3397 - Rewrite the map from threads to tabs (Closed)

Left Patch Set: rebase / fix copyright year Created Feb. 8, 2016, 6:43 p.m.

Right Patch Set: add comment; new function body Created July 17, 2016, 4:01 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 /*	1 /*

2 * This file is part of Adblock Plus <https://adblockplus.org/>,	2 * This file is part of Adblock Plus <https://adblockplus.org/>,

3 * Copyright (C) 2006-2016 Eyeo GmbH	3 * Copyright (C) 2006-2016 Eyeo GmbH

4 *	4 *

5 * Adblock Plus is free software: you can redistribute it and/or modify	5 * Adblock Plus is free software: you can redistribute it and/or modify

6 * it under the terms of the GNU General Public License version 3 as	6 * it under the terms of the GNU General Public License version 3 as

7 * published by the Free Software Foundation.	7 * published by the Free Software Foundation.

8 *	8 *

9 * Adblock Plus is distributed in the hope that it will be useful,	9 * Adblock Plus is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 68 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
79 ~CPluginClass();	79 ~CPluginClass();

80	80

81 // IObjectWithSite	81 // IObjectWithSite

82 STDMETHOD(SetSite)(IUnknown *pUnkSite);	82 STDMETHOD(SetSite)(IUnknown *pUnkSite);

83	83

84 // IOleCommandTarget	84 // IOleCommandTarget

85 STDMETHOD(QueryStatus)(const GUID* pguidCmdGroup, ULONG cCmds, OLECMD prgCmds[ ], OLECMDTEXT* pCmdText);	85 STDMETHOD(QueryStatus)(const GUID* pguidCmdGroup, ULONG cCmds, OLECMD prgCmds[ ], OLECMDTEXT* pCmdText);

86 STDMETHOD(Exec)(const GUID, DWORD nCmdID, DWORD, VARIANTARG, VARIANTARG* pva Out);	86 STDMETHOD(Exec)(const GUID, DWORD nCmdID, DWORD, VARIANTARG, VARIANTARG* pva Out);

87	87

88	88

89 static CPluginTab* GetTabCurrentThread();	89 static CPluginTab* GetTabForCurrentThread();
Oleksandr 2016/02/10 10:58:49 Nit: the name kind of implies the return value wou Nit: the name kind of implies the return value would be a thread, IMO. How about GetTabForCurrentThread? Eric 2016/05/19 17:23:59 Good idea. OK. Show quoted text On 2016/02/10 10:58:49, Oleksandr wrote: > Nit: the name kind of implies the return value would be a thread, IMO. How about > GetTabForCurrentThread? Good idea. OK.
90 CPluginTab* GetTab();	90 CPluginTab* GetTab();

91	91

92 void UpdateStatusBar();	92 void UpdateStatusBar();

93	93

94 private:	94 private:

95	95

96 bool SetMenuBar(HMENU hMenu, const std::wstring& url);	96 bool SetMenuBar(HMENU hMenu, const std::wstring& url);

97 HMENU CreatePluginMenu(const std::wstring& url);	97 HMENU CreatePluginMenu(const std::wstring& url);

98	98

99 void DisplayPluginMenu(HMENU hMenu, int nToolbarCmdID, POINT pt, UINT nMenuFla gs);	99 void DisplayPluginMenu(HMENU hMenu, int nToolbarCmdID, POINT pt, UINT nMenuFla gs);

(...skipping 80 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
180 static CComAutoCriticalSection s_criticalSectionWindow;	180 static CComAutoCriticalSection s_criticalSectionWindow;

181	181

182 // Async browser	182 // Async browser

183 static CComQIPtr<IWebBrowser2> s_asyncWebBrowser2;	183 static CComQIPtr<IWebBrowser2> s_asyncWebBrowser2;

184 static CComQIPtr<IWebBrowser2> GetAsyncBrowser();	184 static CComQIPtr<IWebBrowser2> GetAsyncBrowser();

185 };	185 };

186	186

187 OBJECT_ENTRY_AUTO(__uuidof(PluginClass), CPluginClass)	187 OBJECT_ENTRY_AUTO(__uuidof(PluginClass), CPluginClass)

188	188

189 #endif // _PLUGIN_CLASS_H_	189 #endif // _PLUGIN_CLASS_H_

LEFT	RIGHT