Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Unified Diff: src/plugin/PluginClass.h

Issue 29330403: Issue #1467, #3397 - Rewrite the map from threads to tabs (Closed)
Patch Set: rebase / fix copyright year Created Feb. 8, 2016, 6:43 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/plugin/Instances.h ('K') | « src/plugin/Instances.h ('k') | src/plugin/PluginClass.cpp » ('j') | src/plugin/PluginClass.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/plugin/PluginClass.h
===================================================================
--- a/src/plugin/PluginClass.h
+++ b/src/plugin/PluginClass.h
@@ -41,7 +41,6 @@
class CPluginMimeFilterClient;
-
class ATL_NO_VTABLE CPluginClass :
public ATL::CComObjectRootEx<ATL::CComMultiThreadModel>,
public ATL::CComCoClass<CPluginClass, &CLSID_PluginClass>,
@@ -87,7 +86,7 @@
STDMETHOD(Exec)(const GUID*, DWORD nCmdID, DWORD, VARIANTARG*, VARIANTARG* pvaOut);
- static CPluginTab* GetTab(DWORD dwThreadId);
+ static CPluginTab* GetTabCurrentThread();
Oleksandr 2016/02/10 10:58:49 Nit: the name kind of implies the return value wou
Eric 2016/05/19 17:23:59 Good idea. OK.
CPluginTab* GetTab();
void UpdateStatusBar();
@@ -177,7 +176,6 @@
static HINSTANCE s_hUxtheme;
static std::set<CPluginClass*> s_instances;
- static std::map<DWORD,CPluginClass*> s_threadInstances;
static CComAutoCriticalSection s_criticalSectionLocal;
static CComAutoCriticalSection s_criticalSectionWindow;
@@ -188,5 +186,4 @@
OBJECT_ENTRY_AUTO(__uuidof(PluginClass), CPluginClass)
-
#endif // _PLUGIN_CLASS_H_
« src/plugin/Instances.h ('K') | « src/plugin/Instances.h ('k') | src/plugin/PluginClass.cpp » ('j') | src/plugin/PluginClass.cpp » ('J')

Powered by Google App Engine
This is Rietveld