Issue #1234 - Eliminate CString from PluginSettings.* and PluginUserSettings.*

src/plugin/PluginUserSettings.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include "PluginStdAfx.h"
 #include "PluginUserSettings.h"
 #include "AdblockPlusClient.h"
 #include "PluginSettings.h"
+#include "PluginSystem.h"
 #include "../shared/Dictionary.h"
+#include "../shared/Utils.h"
 #include <unordered_map>
 
 namespace
 {
   enum UserSettingsMethods
   {
     dispatchID_GetMessage = 0,
     dispatchID_GetLanguageCount,
     dispatchID_GetLanguageByIndex,
     dispatchID_GetLanguageTitleByIndex,
@@ skipping 110 matching lines @@
     }
     *id = item->second;
   }
   catch (...)
   {
     return E_FAIL;
   }
   return S_OK;
 }
 
-CStringW sGetMessage(const CString& section, const CString& key)
-{
-  Dictionary* dictionary = Dictionary::GetInstance();
-  return CStringW(dictionary->Lookup(std::string(CW2A(section)), std::string(CW2A(key))).c_str());
-}
-
 STDMETHODIMP CPluginUserSettings::Invoke(DISPID dispidMember, REFIID riid, LCID lcid, WORD wFlags, DISPPARAMS* pDispparams, VARIANT* pVarResult,
                                          EXCEPINFO* pExcepinfo, UINT* pArgErr)
 {
   try
   {
     if (!pDispparams)
     {
       return E_POINTER;
     }
     if (pDispparams->cNamedArgs != 0)
@@ skipping 10 matching lines @@
           return DISP_E_BADPARAMCOUNT;
         }
         if (pDispparams->rgvarg[0].vt != VT_BSTR || pDispparams->rgvarg[1].vt != VT_BSTR)
         {
           return DISP_E_TYPEMISMATCH;
         }
         if (pVarResult)
         {
           CComBSTR key = pDispparams->rgvarg[0].bstrVal;
           CComBSTR section = pDispparams->rgvarg[1].bstrVal;
-          CStringW message = sGetMessage((BSTR)section, (BSTR)key);
+          Dictionary* dictionary = Dictionary::GetInstance();
+          std::wstring message = dictionary->Lookup(
+            ToUtf8String(std::wstring(section, ::SysStringLen(section))),
+            ToUtf8String(std::wstring(key, ::SysStringLen(key)))
+          );
 
           pVarResult->vt = VT_BSTR;
-          pVarResult->bstrVal = SysAllocString(message);
+          pVarResult->bstrVal = SysAllocString(message.c_str());
         }
       }
       break;
     case dispatchID_GetLanguageCount:
       {
         if (pDispparams->cArgs != 0)
         {
           return DISP_E_BADPARAMCOUNT;
         }
         if (pVarResult)
         {
-          std::map<CString, CString> languageList = settings->GetFilterLanguageTitleList();
+          auto languageList = settings->GetFilterLanguageTitleList();
 
           pVarResult->vt = VT_I4;
           pVarResult->lVal = static_cast<LONG>(languageList.size());
         }
       }
       break;
     case dispatchID_GetLanguageByIndex:
       {
         if (pDispparams->cArgs != 1)
         {
           return DISP_E_BADPARAMCOUNT;
         }
         if (pDispparams->rgvarg[0].vt != VT_I4)
         {
           return DISP_E_TYPEMISMATCH;
         }
         if (pVarResult)
         {
           int index = pDispparams->rgvarg[0].lVal;
 
-          std::map<CString, CString> languageTitleList = settings->GetFilterLanguageTitleList();
+          auto languageTitleList = settings->GetFilterLanguageTitleList();
 
           if (index < 0  ||  index >= static_cast<int>(languageTitleList.size()))
             return DISP_E_EXCEPTION;
 
-          CString language;
+          std::wstring language;
 
           int loopIndex = 0;
-          for (std::map<CString, CString>::const_iterator it = languageTitleList.begin(); it != languageTitleList.end(); ++it)
+          for (auto it = languageTitleList.begin(); it != languageTitleList.end(); ++it)
           {
             if (loopIndex == index)
             {
               language = it->first;
               break;
             }
             ++loopIndex;
           }
 
           pVarResult->vt = VT_BSTR;
-          pVarResult->bstrVal = SysAllocString(language);
+          pVarResult->bstrVal = SysAllocString(language.c_str());
         }
       }
       break;
     case dispatchID_GetLanguageTitleByIndex:
       {
         if (pDispparams->cArgs != 1)
         {
           return DISP_E_BADPARAMCOUNT;
         }
         if (pDispparams->rgvarg[0].vt != VT_I4)
         {
           return DISP_E_TYPEMISMATCH;
         }
         if (pVarResult)
         {
           int index = pDispparams->rgvarg[0].lVal;
 
-          std::map<CString, CString> languageTitleList = settings->GetFilterLanguageTitleList();
+          auto languageTitleList = settings->GetFilterLanguageTitleList();
 
           if (index < 0  ||  index >= static_cast<int>(languageTitleList.size()))
             return DISP_E_EXCEPTION;
 
-          CString languageTitle;
-
+          std::wstring languageTitle;
           int loopIndex = 0;
-          for (std::map<CString, CString>::const_iterator it = languageTitleList.begin(); it != languageTitleList.end(); ++it)
+          for (auto it = languageTitleList.begin(); it != languageTitleList.end(); ++it)
           {
             if (loopIndex == index)
             {
               languageTitle = it->second;
               break;
             }
             loopIndex++;
           }
 
           pVarResult->vt = VT_BSTR;
-          pVarResult->bstrVal = SysAllocString(languageTitle);
+          pVarResult->bstrVal = SysAllocString(languageTitle.c_str());
         }
       }
       break;
     case dispatchID_SetLanguage:
       {
         if (pDispparams->cArgs != 1)
         {
           return DISP_E_BADPARAMCOUNT;
         }
         if (pDispparams->rgvarg[0].vt != VT_BSTR)
         {
           return DISP_E_TYPEMISMATCH;
         }
         CComBSTR url = pDispparams->rgvarg[0].bstrVal;
         settings->SetSubscription((BSTR)url);
       }
       break;
     case dispatchID_GetLanguage:
       {
         if (pDispparams->cArgs != 0)
         {
           return DISP_E_BADPARAMCOUNT;
         }
         if (pVarResult)
         {
-          CString url = settings->GetSubscription();
+          std::wstring url = settings->GetSubscription();
           pVarResult->vt = VT_BSTR;
-          pVarResult->bstrVal = SysAllocString(url);
+          pVarResult->bstrVal = SysAllocString(url.c_str());
         }
       }
       break;
     case dispatchID_GetWhitelistDomains:
       {
         if (pDispparams->cArgs != 0)
         {
           return DISP_E_BADPARAMCOUNT;
         }
         if (pVarResult)
         {
-          std::vector<std::wstring> whiteList = settings->GetWhiteListedDomainList();
-          CString sWhiteList;
-          for (size_t i = 0; i < whiteList.size(); i++)
+          auto whiteListDomains = settings->GetWhiteListedDomainList();
+          std::wstring commaSeparatedDomains;
+          for (size_t i = 0; i < whiteListDomains.size(); i++)
           {
-            if (!sWhiteList.IsEmpty())
+            if (!commaSeparatedDomains.empty())
             {
-              sWhiteList += ',';
+              commaSeparatedDomains += ',';
             }
-            sWhiteList += CString(whiteList[i].c_str());
+            commaSeparatedDomains += whiteListDomains[i];
           }
           pVarResult->vt = VT_BSTR;
-          pVarResult->bstrVal = SysAllocString(sWhiteList);
+          pVarResult->bstrVal = SysAllocString(commaSeparatedDomains.c_str());
         }
       }
       break;
     case dispatchID_AddWhitelistDomain:
       {
         if (pDispparams->cArgs != 1)
         {
           return DISP_E_BADPARAMCOUNT;
         }
         if (pDispparams->rgvarg[0].vt != VT_BSTR)
@@ skipping 13 matching lines @@
         {
           return DISP_E_BADPARAMCOUNT;
         }
         if (pDispparams->rgvarg[0].vt != VT_BSTR)
         {
           return DISP_E_TYPEMISMATCH;
         }
         CComBSTR domain = pDispparams->rgvarg[0].bstrVal;
         if (domain.Length())
         {
-          settings->RemoveWhiteListedDomain((BSTR)domain);
+          settings->RemoveWhiteListedDomain(std::wstring(domain));
         }
       }
       break;
     case dispatchID_GetAppLocale:
       {
         if (pDispparams->cArgs != 0)
         {
           return DISP_E_BADPARAMCOUNT;
         }
         if (pVarResult)
         {
           pVarResult->vt = VT_BSTR;
-          pVarResult->bstrVal = SysAllocString(settings->GetAppLocale());
+          pVarResult->bstrVal = SysAllocString(GetBrowserLanguage().c_str());
         }
       }
       break;
     case dispatchID_GetDocumentationLink:
       {
         if (pDispparams->cArgs != 0)
         {
           return DISP_E_BADPARAMCOUNT;
         }
         if (pVarResult)
         {
           pVarResult->vt = VT_BSTR;
-          pVarResult->bstrVal = SysAllocString(settings->GetDocumentationLink());
+          pVarResult->bstrVal = SysAllocString(CPluginClient::GetInstance()->GetDocumentationLink().c_str());
         }
       }
       break;
     case dispatchID_IsAcceptableAdsEnabled:
       {
         if (pDispparams->cArgs != 0)
         {
           return DISP_E_BADPARAMCOUNT;
         }
         if (pVarResult)
@@ skipping 42 matching lines @@
       return DISP_E_MEMBERNOTFOUND;
       break;
     }
   }
   catch (...)
   {
     return E_FAIL;
   }
   return S_OK;
 }