Issue #1234 - Eliminate CString from PluginSettings.* and PluginUserSettings.*

src/plugin/PluginSettings.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 85 matching lines @@
 }
 
 std::map<std::wstring, std::wstring> CPluginSettings::GetFilterLanguageTitleList() const
 {
   auto subscriptions = CPluginClient::GetInstance()->FetchAvailableSubscriptions();
 
   std::map<std::wstring, std::wstring> filterList;
   for (size_t i = 0; i < subscriptions.size(); i ++)
   {
     auto it = subscriptions[i];
-    filterList.insert(std::make_pair(it.url,it.title));

[sergei, 2015/11/25 09:27:08]

the space after comma is missed

[Eric, 2015/11/25 17:31:02]

Done.

+    filterList.insert(std::make_pair(it.url, it.title));
   }
   return filterList;
 }
 
 bool CPluginSettings::IsWorkingThread(DWORD dwThreadId) const
 {
   if (dwThreadId == 0)
   {
     dwThreadId = ::GetCurrentThreadId();
   }
@@ skipping 136 matching lines @@
 
   for (auto subscription = subscriptions.begin(); subscription != subscriptions.end(); subscription++)
   {
     if (subscription->url != aaUrl)
     {
       return subscription->url;
     }
   }
   return std::wstring();
 }