Issue #1234 - Eliminate CString from PluginSettings.* and PluginUserSettings.*

src/plugin/PluginSettings.h

Index: src/plugin/PluginSettings.h
===================================================================
--- a/src/plugin/PluginSettings.h
+++ b/src/plugin/PluginSettings.h
@@ -71,7 +71,7 @@
 
   bool IsPluginEnabled() const;
 
-  std::map<CString, CString> GetFilterLanguageTitleList() const;
+  std::map<std::wstring, std::wstring> GetFilterLanguageTitleList() const;
 
   void SetWorkingThreadId();
   void SetWorkingThreadId(DWORD id);
@@ -93,8 +93,8 @@
   bool ReadWhitelist(bool bDebug=true);
 
 public:
-  void AddWhiteListedDomain(const CString& domain);
-  void RemoveWhiteListedDomain(const CString& domain);
+  void AddWhiteListedDomain(const std::wstring& domain);
+  void RemoveWhiteListedDomain(const std::wstring& domain);
   int GetWhiteListedDomainCount() const;
   std::vector<std::wstring> GetWhiteListedDomainList();
 
@@ -102,10 +102,7 @@
   DWORD GetWindowsBuildNumber();
 
   void SetSubscription(const std::wstring& url);
-  void SetDefaultSubscription();
-  CString GetSubscription();
-  CString GetAppLocale();
-  CString GetDocumentationLink();

[Eric, 2015/11/20 18:46:04]

Inlined.

+  std::wstring GetSubscription();
 };
 
 std::wstring GetDataPath(const std::wstring& filename=L"");