Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(554)

Issue 29330720: Issue 3326 - Make sure to include common.js file required by the latest revision of the first-run p… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 6 months ago by Wladimir Palant
Modified:
4 years, 6 months ago
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Issue 3326 - Make sure to include common.js file required by the latest revision of the first-run p…

Patch Set 1 #

Patch Set 2 : Added styles #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M metadata.gecko View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
4 years, 6 months ago (2015-11-23 20:52:52 UTC) #1
Thomas Greiner
This is not sufficient. As noted in https://issues.adblockplus.org/ticket/2381#Notesfordependencyupdate common.css also needs to be imported. It ...
4 years, 6 months ago (2015-11-23 20:55:37 UTC) #2
Wladimir Palant
Right, I added the styles as well.
4 years, 6 months ago (2015-11-23 20:58:20 UTC) #3
Thomas Greiner
4 years, 6 months ago (2015-11-23 21:00:07 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5