Issue 29330816: Noissue, Dead Code - Remove Windows build number from CPluginSettings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29330816: Noissue, Dead Code - Remove Windows build number from CPluginSettings (Closed)

Created:
Nov. 25, 2015, 6:28 p.m. by Eric

Modified:
Nov. 26, 2015, 12:51 p.m.

Reviewers:
sergei, Oleksandr

CC:
Felix Dahlke

Visibility:
Public.

Description

Noissue, Dead Code - Remove Windows build number from CPluginSettings Remove GetWindowsBuildNumber(), which is never called. Remove m_WindowsBuildNumber, whose value was not used outside GetWindowsBuildNumber().

Patch Set 1 #

Created: Nov. 25, 2015, 6:28 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -19 lines)			Patch
	M	src/plugin/PluginSettings.h	View		2 chunks	+0 lines, -3 lines	0 comments	Download
	M	src/plugin/PluginSettings.cpp	View		2 chunks	+0 lines, -16 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages