Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29331049: Issue 3354 - Enable extras module for Markdown inside HTML blocks (Closed)

Created:
Nov. 26, 2015, 1:29 p.m. by kzar
Modified:
Nov. 27, 2015, 9:51 a.m.
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 3354 - Enable extras module for Markdown inside HTML blocks

Patch Set 1 #

Total comments: 4

Patch Set 2 : Removed redundant attr_list extension, updated README #

Total comments: 6

Patch Set 3 : Addressed Sebastian's feedback #

Patch Set 4 : Update hidden dependency in runserver.spec #

Total comments: 3

Patch Set 5 : Add all Markdown extra extensions to hiddenimports list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M README.md View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M cms/converters.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runserver.spec View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12
kzar
Patch Set 1
Nov. 26, 2015, 1:31 p.m. (2015-11-26 13:31:15 UTC) #1
saroyanm
https://codereview.adblockplus.org/29331049/diff/29331050/cms/converters.py File cms/converters.py (right): https://codereview.adblockplus.org/29331049/diff/29331050/cms/converters.py#newcode314 cms/converters.py:314: extensions=["attr_list", "markdown.extensions.extra"]) According to documentation extra extension include attr_list ...
Nov. 26, 2015, 1:49 p.m. (2015-11-26 13:49:50 UTC) #2
kzar
Patch Set 2 : Removed redundant attr_list extension, updated README https://codereview.adblockplus.org/29331049/diff/29331050/cms/converters.py File cms/converters.py (right): https://codereview.adblockplus.org/29331049/diff/29331050/cms/converters.py#newcode314 ...
Nov. 26, 2015, 2:01 p.m. (2015-11-26 14:01:34 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29331049/diff/29331050/cms/converters.py File cms/converters.py (right): https://codereview.adblockplus.org/29331049/diff/29331050/cms/converters.py#newcode314 cms/converters.py:314: extensions=["attr_list", "markdown.extensions.extra"]) On 2015/11/26 14:01:34, kzar wrote: > On ...
Nov. 26, 2015, 2:23 p.m. (2015-11-26 14:23:51 UTC) #4
saroyanm
https://codereview.adblockplus.org/29331049/diff/29331050/cms/converters.py File cms/converters.py (right): https://codereview.adblockplus.org/29331049/diff/29331050/cms/converters.py#newcode314 cms/converters.py:314: extensions=["attr_list", "markdown.extensions.extra"]) On 2015/11/26 14:01:34, kzar wrote: > On ...
Nov. 26, 2015, 2:29 p.m. (2015-11-26 14:29:48 UTC) #5
kzar
Patch Set 3 : Addressed Sebastian's feedback https://codereview.adblockplus.org/29331049/diff/29331052/README.md File README.md (right): https://codereview.adblockplus.org/29331049/diff/29331052/README.md#newcode211 README.md:211: HTML tags, ...
Nov. 26, 2015, 2:41 p.m. (2015-11-26 14:41:24 UTC) #6
saroyanm
LGTM
Nov. 26, 2015, 2:44 p.m. (2015-11-26 14:44:35 UTC) #7
Sebastian Noack
You forgot to adapt the hidden imports in runserver.spec
Nov. 26, 2015, 9:17 p.m. (2015-11-26 21:17:46 UTC) #8
kzar
Patch Set 4 : Update hidden dependency in runserver.spec https://codereview.adblockplus.org/29331049/diff/29331101/runserver.spec File runserver.spec (right): https://codereview.adblockplus.org/29331049/diff/29331101/runserver.spec#newcode22 runserver.spec:22: ...
Nov. 27, 2015, 9:11 a.m. (2015-11-27 09:11:17 UTC) #9
Sebastian Noack
https://codereview.adblockplus.org/29331049/diff/29331101/runserver.spec File runserver.spec (right): https://codereview.adblockplus.org/29331049/diff/29331101/runserver.spec#newcode22 runserver.spec:22: 'markdown.extensions.extra', That isn't sufficient as the extensions included with ...
Nov. 27, 2015, 9:28 a.m. (2015-11-27 09:28:34 UTC) #10
kzar
Patch Set 5 : Add all Markdown extra extensions to hiddenimports list https://codereview.adblockplus.org/29331049/diff/29331101/runserver.spec File runserver.spec ...
Nov. 27, 2015, 9:45 a.m. (2015-11-27 09:45:31 UTC) #11
Sebastian Noack
Nov. 27, 2015, 9:47 a.m. (2015-11-27 09:47:45 UTC) #12
LGTM

Powered by Google App Engine
This is Rietveld