Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: adblockplus.gyp

Issue 29331055: Issue #1234 - Remove 'CString' from PluginFilter.* (Closed)
Patch Set: Created Nov. 29, 2015, 3:49 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/plugin/PluginFilter.h » ('j') | src/plugin/PluginFilter.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 { 1 {
2 'includes': [ 2 'includes': [
3 'defaults.gypi', 3 'defaults.gypi',
4 'common/common.gypi', 4 'common/common.gypi',
5 ], 5 ],
6 6
7 'variables': { 7 'variables': {
8 'build_type%': 'devbuild', 8 'build_type%': 'devbuild',
9 'build_version%': '', 9 'build_version%': '',
10 }, 10 },
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 ], 213 ],
214 'sources': [ 214 'sources': [
215 'test/CommunicationTest.cpp', 215 'test/CommunicationTest.cpp',
216 'test/DictionaryTest.cpp', 216 'test/DictionaryTest.cpp',
217 'test/UtilTest.cpp', 217 'test/UtilTest.cpp',
218 'test/UtilGetQueryStringTest.cpp', 218 'test/UtilGetQueryStringTest.cpp',
219 'test/UtilGetSchemeAndHierarchicalPartTest.cpp', 219 'test/UtilGetSchemeAndHierarchicalPartTest.cpp',
220 ], 220 ],
221 'defines': ['WINVER=0x0501'], 221 'defines': ['WINVER=0x0501'],
222 'link_settings': { 222 'link_settings': {
223 'libraries': ['-ladvapi32', '-lshell32', '-lole32'], 223 'libraries': ['-ladvapi32', '-lshell32', '-lole32', '-loleaut32'],
sergei 2015/11/30 12:37:51 Why do we need it?
Eric 2015/11/30 15:54:05 SysStringLen, used in ToWstring(BSTR) Apparently
224 }, 224 },
225 'msvs_settings': { 225 'msvs_settings': {
226 'VCLinkerTool': { 226 'VCLinkerTool': {
227 'SubSystem': '1', # Console 227 'SubSystem': '1', # Console
228 'EntryPointSymbol': 'mainCRTStartup', 228 'EntryPointSymbol': 'mainCRTStartup',
229 }, 229 },
230 }, 230 },
231 }, 231 },
232 232
233 { 233 {
234 'target_name': 'tests_plugin', 234 'target_name': 'tests_plugin',
235 'type': 'executable', 235 'type': 'executable',
236 'dependencies': [ 236 'dependencies': [
237 'shared', 237 'shared',
238 'libadblockplus/libadblockplus.gyp:libadblockplus', 238 'libadblockplus/libadblockplus.gyp:libadblockplus',
239 'libadblockplus/third_party/googletest.gyp:googletest_main', 239 'libadblockplus/third_party/googletest.gyp:googletest_main',
240 ], 240 ],
241 'sources': [ 241 'sources': [
242 'src/plugin/PluginUserSettings.cpp', 242 'src/plugin/PluginUserSettings.cpp',
243 'src/plugin/PluginUserSettings.h', 243 'src/plugin/PluginUserSettings.h',
244 'test/plugin/UserSettingsTest.cpp', 244 'test/plugin/UserSettingsTest.cpp',
245 'src/plugin/PluginUtil.h', 245 'src/plugin/PluginUtil.h',
246 'test/plugin/UtilTest.cpp', 246 'test/plugin/UtilTest.cpp',
247 'src/plugin/TokenSequence.h',
248 'test/plugin/TokenSequenceTest.cpp',
247 # 249 #
248 # required only for linking 250 # required only for linking
249 # 251 #
250 'src/plugin/AdblockPlusClient.cpp', 252 'src/plugin/AdblockPlusClient.cpp',
251 'src/plugin/AdblockPlusDomTraverser.cpp', 253 'src/plugin/AdblockPlusDomTraverser.cpp',
252 'src/plugin/ATL_Deprecate.cpp', 254 'src/plugin/ATL_Deprecate.cpp',
253 'src/plugin/NotificationMessage.cpp', 255 'src/plugin/NotificationMessage.cpp',
254 'src/plugin/Plugin.cpp', 256 'src/plugin/Plugin.cpp',
255 'src/plugin/PluginClientBase.cpp', 257 'src/plugin/PluginClientBase.cpp',
256 'src/plugin/PluginClientFactory.cpp', 258 'src/plugin/PluginClientFactory.cpp',
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
308 'Release': { 310 'Release': {
309 'msvs_settings': { 311 'msvs_settings': {
310 'VCLinkerTool': { 312 'VCLinkerTool': {
311 'AdditionalDependencies': ['atls.lib'], 313 'AdditionalDependencies': ['atls.lib'],
312 }, 314 },
313 }, 315 },
314 }, 316 },
315 }, 317 },
316 }] 318 }]
317 } 319 }
OLDNEW
« no previous file with comments | « no previous file | src/plugin/PluginFilter.h » ('j') | src/plugin/PluginFilter.h » ('J')

Powered by Google App Engine
This is Rietveld