Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/engine/NotificationWindow.cpp

Issue 29331537: Noissue - Change argument of 'GetHtmlElementAttribute()' to 'std::wstring'
Patch Set: rebase only Created May 17, 2016, 7:40 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/plugin/PluginFilter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/engine/NotificationWindow.cpp
===================================================================
--- a/src/engine/NotificationWindow.cpp
+++ b/src/engine/NotificationWindow.cpp
@@ -231,7 +231,7 @@
if (_wcsnicmp(tag, expectedTag, min(sizeof(expectedTag), tag.Length())) != 0) {
return;
}
- auto classAttr = GetHtmlElementAttribute(*htmlElement, ATL::CComBSTR(L"class"));
+ auto classAttr = GetHtmlElementAttribute(*htmlElement, L"class");
if (classAttr.attributeValue == L"closeButton")
{
if (m_onCloseCallback)
@@ -242,7 +242,7 @@
{
return;
}
- auto linkIDAttr = GetHtmlElementAttribute(*htmlElement, ATL::CComBSTR(L"data-linkID"));
+ auto linkIDAttr = GetHtmlElementAttribute(*htmlElement, L"data-linkID");
uint32_t linkID = 0;
if (!linkIDAttr.attributeValue.empty() && (linkID = std::stoi(linkIDAttr.attributeValue)) < m_links.size())
{
« no previous file with comments | « no previous file | src/plugin/PluginFilter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld