Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/shared/MsHTMLUtils.cpp

Issue 29331537: Noissue - Change argument of 'GetHtmlElementAttribute()' to 'std::wstring'
Patch Set: rebase only Created May 17, 2016, 7:40 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/shared/MsHTMLUtils.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/shared/MsHTMLUtils.cpp
===================================================================
--- a/src/shared/MsHTMLUtils.cpp
+++ b/src/shared/MsHTMLUtils.cpp
@@ -18,7 +18,7 @@
#include "MsHTMLUtils.h"
GetHtmlElementAttributeResult GetHtmlElementAttribute(IHTMLElement& htmlElement,
- const ATL::CComBSTR& attributeName)
+ const std::wstring& attributeName)
{
GetHtmlElementAttributeResult retValue;
ATL::CComVariant vAttr;
@@ -28,7 +28,8 @@
return retValue;
}
ATL::CComPtr<IHTMLDOMAttribute> attributeNode;
- if (FAILED(htmlElement4->getAttributeNode(attributeName, &attributeNode)) || !attributeNode)
+ ATL::CComBSTR attributeNameArg(attributeName.length(), attributeName.c_str());
+ if (FAILED(htmlElement4->getAttributeNode(attributeNameArg, &attributeNode)) || !attributeNode)
{
return retValue;
}
« no previous file with comments | « src/shared/MsHTMLUtils.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld