Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29331643: Noissue - Make the use of 'QueryInterface' calls consistent (Closed)

Created:
Nov. 30, 2015, 6:01 p.m. by Eric
Modified:
Dec. 1, 2015, 12:26 p.m.
Reviewers:
sergei, Oleksandr
CC:
Felix Dahlke
Visibility:
Public.

Description

Noissue - Make the use of 'QueryInterface' calls consistent Replace calls to 'QueryInterface' that include an explicit IID argument with calls to the template version of 'QueryInterface' that infers the IID from the type of its [out] argument. Corrected a defect where absence of a pointer check could lead to indirection through a null pointer. Change the initialization of some 'CComQIPtr' variables to use the syntax for direct construction rather than implicit conversion and assignment. These were not causing compile errors but were causing spurious Intellisense errors within Visual Studio.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M src/plugin/PluginDomTraverserBase.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/plugin/PluginTabBase.cpp View 3 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 3
Eric
Nov. 30, 2015, 6:08 p.m. (2015-11-30 18:08:21 UTC) #1
sergei
LGTM
Nov. 30, 2015, 6:16 p.m. (2015-11-30 18:16:13 UTC) #2
Oleksandr
Dec. 1, 2015, 1:04 a.m. (2015-12-01 01:04:40 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld