Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/plugin/PluginWbPassThrough.cpp

Issue 29331669: Issue 3237 - Whitelisted AFS ad is not shown on netzwelt.de (Closed)
Patch Set: Created Dec. 1, 2015, 2:15 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/plugin/PluginDomTraverserBase.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/plugin/PluginWbPassThrough.cpp
===================================================================
--- a/src/plugin/PluginWbPassThrough.cpp
+++ b/src/plugin/PluginWbPassThrough.cpp
@@ -146,6 +146,13 @@
{
if (mimeType.find(L"image/") != std::wstring::npos)
{
+ // Ambivalent mime type suggests both image and other types.
+ // Heuristically this is more likely a SUBDOCUMENT request.
+ if ((mimeType.find(L"text/") != std::wstring::npos) ||
sergei 2015/12/01 10:53:59 In IE11 on my machine Accept header for "subdocume
Eric 2015/12/01 20:32:57 We don't have anything like a crawler for IE, but
Oleksandr 2015/12/15 02:10:16 I have only been able to log 2 types here: text/ht
Eric 2015/12/15 03:18:18 These are the strings I'd like to see in a comment
+ (mimeType.find(L"application/") != std::wstring::npos))
+ {
+ return ContentType::CONTENT_TYPE_SUBDOCUMENT;
+ }
return ContentType::CONTENT_TYPE_IMAGE;
}
if (mimeType.find(L"text/css") != std::wstring::npos)
« no previous file with comments | « src/plugin/PluginDomTraverserBase.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld