Noissue - Add tracing function 'ToHexLiteral()'

src/plugin/PluginDebug.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include "PluginStdAfx.h"
 #include "PluginDebug.h"
 #include "PluginClientBase.h"
 #include "PluginMutex.h"
 #include "PluginSettings.h"
+#include <cstdint>
 
 class CPluginDebugLock : public CPluginMutex
 {
 
 private:
 
   static CComAutoCriticalSection s_criticalSectionDebugLock;
 
 public:
 
@@ skipping 216 matching lines @@
     srcTrunc = srcTrunc.Left(67) + L"..." + srcTrunc.Right(30);
   }
 
   CString blocking;
   blocking.Format(L"Ignored  %-12s  %s  %s", ToCString(type), domain.empty()? L"-" : ToCString(domain), srcTrunc);
 
   DebugResultLegacy(blocking);
 }
 
 #endif // ENABLE_DEBUG_RESULT_IGNORED
+
+namespace
+{
+  /*
+   * To convert a pointer to a hexadecimal number, we need an integral type that has the same size as that of the pointer.
+   */
+#if defined(_WIN64)
+  typedef uint64_t voidIntegral;
+  static_assert(sizeof(void*)==sizeof(voidIntegral),"WIN64: sizeof(uint64_t) is not the same as sizeof(void*)");
+#elif defined(_WIN32)
+  typedef uint32_t voidIntegral;
+  static_assert(sizeof(void*)==sizeof(voidIntegral),"WIN32: sizeof(uint32_t) is not the same as sizeof(void*)");
+#else
+#error Must compile with either _WIN32 or _WIN64
+#endif
+}
+
+std::wstring ToHexLiteral(void const* p)

[sergei, 2016/01/05 10:55:27]

How does it happen that in header it's `const void*` but in cpp file it's `void
const* p`?

[Eric, 2016/01/05 14:38:26]

Not using copy-paste, in all likelihood. I really don't recall; I wrote this
code months ago.

+{
+  std::wstringstream ss;
+  ss << L"0x";
+  ss.width(sizeof(p) * 2);
+  ss.fill(L'0');
+  ss << std::hex << reinterpret_cast<voidIntegral>(p);
+  return ss.str();
+}