Noissue - Add tracing function 'ToHexLiteral()'

test/plugin/DebugTest.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 11 matching lines @@
 #if defined(_WIN64)
 #define expected_length 18
 #define expected_nullptr_literal L"0x0000000000000000"
 #elif defined(_WIN32)
 #define expected_length 10
 #define expected_nullptr_literal L"0x00000000"
 #endif
 
 TEST(ToHexLiteral, Null)
 {
   ASSERT_EQ(expected_nullptr_literal, ToHexLiteral(nullptr));

[sergei, 2015/12/07 11:04:02]

As before, what about using EXPECT_* instead of ASSERT_* in this file ?

[Eric, 2015/12/07 13:06:57]

There's no difference between these two when there's only one of them in the
test. There's no need for niggling consistency on this point. Can we please stop
wasting time going over this again and again?

 }
 
 TEST(ToHexLiteral, NotNull)
 {
-  std::unique_ptr<int> p(new int);

[sergei, 2015/12/07 11:04:02]

It can be simply int p = 0; without allocating of a memory and one can pass `&p`
into as the function parameter.

[Eric, 2015/12/07 13:06:57]

Done.

-  ASSERT_NE(p, nullptr);
-  ASSERT_EQ(expected_length, ToHexLiteral(p.get()).length());
+  int p = 0;
+  ASSERT_NE(&p, nullptr);
+  ASSERT_EQ(expected_length, ToHexLiteral(&p).length());
 }