Noissue - Add tracing function 'ToHexLiteral()'

src/plugin/PluginDebug.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 246 matching lines @@
 }
 
 #endif // ENABLE_DEBUG_RESULT_IGNORED
 
 namespace
 {
   /*
    * To convert a pointer to a hexadecimal number, we need an integral type that has the same size as that of the pointer.
    */
 #if defined(_WIN64)
   typedef uint64_t voidIntegral;

[sergei, 2015/12/21 11:14:28]

What about using of `uintptr_t` but pay attention that its size can be different
from the size of void*.

[Eric, 2015/12/21 12:51:59]

Already changed it once at your suggestion. We are now squarely in bikeshedding
territory.
https://en.wikipedia.org/wiki/Parkinson's_law_of_triviality

Look, we're using 'reinterpret_cast', so the exact type hardly matters much. It
needs to be an unsigned integral type and it needs to be the same size as a
pointer. By these criteria, 'uintptr_t' isn't even desirable. Its size is >=
size of a pointer; it's not guaranteed to be the same size.

[sergei, 2015/12/21 13:04:47]

According to http://en.cppreference.com/w/cpp/language/reinterpret_cast it
should work.

[Eric, 2015/12/21 13:19:59]

OK. Great. I didn't say it wouldn't work. I said it was inferior to what we had.

We have explicit 'static_assert' size checks. Very little matters after that.

[sergei, 2015/12/21 13:37:09]

Less code less bugs, I think here it's proper place when we should use this
rule.

-  static_assert(sizeof(void*)==sizeof(voidIntegral),"WIN64: sizeof(long long) is not the same as sizeof(void*)");

[sergei, 2015/12/21 11:14:28]

Here and below the message string is inconsistent with the actual type which is
uint64_t

[Eric, 2015/12/21 12:51:59]

Done.

+  static_assert(sizeof(void*)==sizeof(voidIntegral),"WIN64: sizeof(uint64_t) is not the same as sizeof(void*)");
 #elif defined(_WIN32)
   typedef uint32_t voidIntegral;
-  static_assert(sizeof(void*)==sizeof(voidIntegral),"WIN32: sizeof(long) is not the same as sizeof(void*)");
+  static_assert(sizeof(void*)==sizeof(voidIntegral),"WIN32: sizeof(uint32_t) is not the same as sizeof(void*)");
 #else
 #error Must compile with either _WIN32 or _WIN64
 #endif
 }
 
 std::wstring ToHexLiteral(void const* p)

[sergei, 2016/01/05 10:55:27]

How does it happen that in header it's `const void*` but in cpp file it's `void
const* p`?

[Eric, 2016/01/05 14:38:26]

Not using copy-paste, in all likelihood. I really don't recall; I wrote this
code months ago.

 {
   std::wstringstream ss;
   ss << L"0x";
   ss.width(sizeof(p) * 2);
   ss.fill(L'0');
   ss << std::hex << reinterpret_cast<voidIntegral>(p);
   return ss.str();
 }