Issue 3381 - notification unit tests are broken

lib/notification.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 /**
  * @fileOverview Handles notifications.
  */
 
 Cu.import("resource://gre/modules/Services.jsm");
 
-let {Prefs} = require("prefs");
-let {Downloader, Downloadable, MILLIS_IN_MINUTE, MILLIS_IN_HOUR, MILLIS_IN_DAY} = require("downloader");
-let {Utils} = require("utils");
-let {Matcher, defaultMatcher} = require("matcher");
-let {Filter, RegExpFilter, WhitelistFilter} = require("filterClasses");
+var {Prefs} = require("prefs");
+var {Downloader, Downloadable, MILLIS_IN_MINUTE, MILLIS_IN_HOUR, MILLIS_IN_DAY} = require("downloader");
+var {Utils} = require("utils");
+var {Matcher, defaultMatcher} = require("matcher");
+var {Filter, RegExpFilter, WhitelistFilter} = require("filterClasses");
 
-let INITIAL_DELAY = 1 * MILLIS_IN_MINUTE;
-let CHECK_INTERVAL = 1 * MILLIS_IN_HOUR;
-let EXPIRATION_INTERVAL = 1 * MILLIS_IN_DAY;
-let TYPE = {
+var INITIAL_DELAY = 1 * MILLIS_IN_MINUTE;
+var CHECK_INTERVAL = 1 * MILLIS_IN_HOUR;
+var EXPIRATION_INTERVAL = 1 * MILLIS_IN_DAY;
+var TYPE = {
   information: 0,
   question: 1,
   critical: 2
 };
 
-let showListeners = [];
-let questionListeners = {};
+var showListeners = [];
+var questionListeners = {};
 
 function getNumericalSeverity(notification)
 {
   return (notification.type in TYPE ? TYPE[notification.type] : TYPE.information);
 }
 
 function saveNotificationData()
 {
   // HACK: JSON values aren't saved unless they are assigned a different object.
   Prefs.notificationdata = JSON.parse(JSON.stringify(Prefs.notificationdata));
 }
 
 function localize(translations, locale)
 {
   if (locale in translations)
     return translations[locale];
 
   let languagePart = locale.substring(0, locale.indexOf("-"));
   if (languagePart && languagePart in translations)
     return translations[languagePart];
 
   let defaultLocale = "en-US";
   return translations[defaultLocale];
 }
 
 /**
  * The object providing actual downloading functionality.
  * @type Downloader
  */
-let downloader = null;
-let localData = [];
+var downloader = null;
+var localData = [];
 
 /**
  * Regularly fetches notifications and decides which to show.
  * @class
  */
-let Notification = exports.Notification =
+var Notification = exports.Notification =
 {
   /**
    * Called on module startup.
    */
   init: function()
   {
     downloader = new Downloader(this._getDownloadables.bind(this), INITIAL_DELAY, CHECK_INTERVAL);
     downloader.onExpirationChange = this._onExpirationChange.bind(this);
     downloader.onDownloadSuccess = this._onDownloadSuccess.bind(this);
     downloader.onDownloadError = this._onDownloadError.bind(this);
@@ skipping 315 matching lines @@
       Prefs.notifications_showui = true;
     }
     else if (index != -1 && forceValue !== true)
       categories.splice(index, 1);
 
     // HACK: JSON values aren't saved unless they are assigned a different object.
     Prefs.notifications_ignoredcategories = JSON.parse(JSON.stringify(categories));
   }
 };
 Notification.init();