Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29332065: Issue 3380 - synchronizer unit tests are broken (Closed)

Created:
Dec. 7, 2015, 3:45 p.m. by Erik
Modified:
Jan. 8, 2016, 10:09 p.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 3380 - synchronizer unit tests are broken Make the affected variables properly global (change `let` to `var`). Changes described in: https://blog.mozilla.org/addons/2015/10/14/breaking-changes-let-const-firefox-nightly-44/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M lib/synchronizer.js View 1 chunk +12 lines, -12 lines 0 comments Download

Messages

Total messages: 2
Erik
Dec. 28, 2015, 12:14 p.m. (2015-12-28 12:14:49 UTC) #1
Wladimir Palant
Jan. 7, 2016, 9:08 p.m. (2016-01-07 21:08:12 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld