Issue #1596, #1720 - Make status bar menu consistent with plugin abilities

src/plugin/PluginTabBase.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 57 matching lines @@
   std::wstring GetDocumentUrl();
   virtual void OnActivate();
   virtual void OnUpdate();
   virtual void OnNavigate(const std::wstring& url);
   virtual void OnDownloadComplete(IWebBrowser2* browser);
   virtual void OnDocumentComplete(IWebBrowser2* browser, const std::wstring& url, bool isDocumentBrowser);
   static DWORD WINAPI TabThreadProc(LPVOID pParam);
   void CacheFrame(const std::wstring& url);
   bool IsFrameCached(const std::wstring& url);
   void ClearFrameCache(const std::wstring& domain=L"");
-  /*
-   * Is it possible to disable the current content on a per-site basis?

[sergei, 2015/12/08 20:20:19]

This comment is unclear because it's not clear what the current content it is
told here about and it's not question whether it's possible or not on a per-site
basis.

Actually the method should indicate whether it makes sense and possible to
either enable or disable ABP on the current web site.

[Eric, 2015/12/09 12:48:35]

Tabs have current content displayed in the browser tab window. What's confusing
about that?
Well, that's what it says in the function name.

I've renamed the function to avoid the use of the English modal verb "can",
which likely doesn't translate easily.

-   *
-   * ABP only intercepts protocols "http:" and "https:",

[sergei, 2015/12/08 20:20:19]

I would rather move it into the method body because it explains the magic
strings used there.

[Eric, 2015/12/09 12:48:35]

Done.

-   *   so it makes no sense to offer the user an option to block content from other protocols.

[sergei, 2015/12/08 20:20:19]

I bit unusual formatting with two spaces gap.

[Eric, 2015/12/09 12:48:35]

I rewrote this piece of the comment entirely.

+  /**
+   * Is it possible to disable the current content of the present tab on a per-site basis?
    */
-  bool CanDisableOnSite();
+  bool IsPossibleToDisableOnSite();
 };
 
 /**
  * Temporary class used during refactoring.
  * This is the definition previously in AdblockPlusTab.h
  * Defining this class during refactoring alleviates the need to rename CPluginTabBase in the first change set.
  */
 class CPluginTab : public CPluginTabBase
 {
 
 public:
   CPluginTab(CPluginClass* plugin) : CPluginTabBase(plugin) {};
   ~CPluginTab() {};
 };
 
 
 
 #endif // _PLUGIN_TAB_BASE_H_