Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/plugin/PluginTabBase.h

Issue 29332455: Issue #1596, #1720 - Make status bar menu consistent with plugin abilities (Closed)
Patch Set: Created Dec. 8, 2015, 6:58 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/plugin/PluginClass.cpp ('k') | src/plugin/PluginTabBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/plugin/PluginTabBase.h
===================================================================
--- a/src/plugin/PluginTabBase.h
+++ b/src/plugin/PluginTabBase.h
@@ -75,7 +75,13 @@
void CacheFrame(const std::wstring& url);
bool IsFrameCached(const std::wstring& url);
void ClearFrameCache(const std::wstring& domain=L"");
-
+ /*
+ * Is it possible to disable the current content on a per-site basis?
sergei 2015/12/08 20:20:19 This comment is unclear because it's not clear wha
Eric 2015/12/09 12:48:35 Tabs have current content displayed in the browser
+ *
+ * ABP only intercepts protocols "http:" and "https:",
sergei 2015/12/08 20:20:19 I would rather move it into the method body becaus
Eric 2015/12/09 12:48:35 Done.
+ * so it makes no sense to offer the user an option to block content from other protocols.
sergei 2015/12/08 20:20:19 I bit unusual formatting with two spaces gap.
Eric 2015/12/09 12:48:35 I rewrote this piece of the comment entirely.
+ */
+ bool CanDisableOnSite();
};
/**
« no previous file with comments | « src/plugin/PluginClass.cpp ('k') | src/plugin/PluginTabBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld