safari/ext/common.js - Issue 29332492: Issue 3269 - Display uninstallation page when uninstalled

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: safari/ext/common.js

Issue 29332492: Issue 3269 - Display uninstallation page when uninstalled (Closed)

Patch Set: Addressed feedback Created Dec. 10, 2015, 2:27 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * This file is part of Adblock Plus <https://adblockplus.org/>,	2 * This file is part of Adblock Plus <https://adblockplus.org/>,

3 * Copyright (C) 2006-2015 Eyeo GmbH	3 * Copyright (C) 2006-2015 Eyeo GmbH

4 *	4 *

5 * Adblock Plus is free software: you can redistribute it and/or modify	5 * Adblock Plus is free software: you can redistribute it and/or modify

6 * it under the terms of the GNU General Public License version 3 as	6 * it under the terms of the GNU General Public License version 3 as

7 * published by the Free Software Foundation.	7 * published by the Free Software Foundation.

8 *	8 *

9 * Adblock Plus is distributed in the hope that it will be useful,	9 * Adblock Plus is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 202 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
213 }	213 }

214 };	214 };

215	215

216	216

217 /* Utils */	217 /* Utils */

218	218

219 ext.getURL = function(path)	219 ext.getURL = function(path)

220 {	220 {

221 return safari.extension.baseURI + path;	221 return safari.extension.baseURI + path;

222 };	222 };

	223 ext.setUninstallURL = function (url) { };
	Sebastian Noack 2015/12/12 00:31:09 This is dead code. Dead code is bad, regardless ho This is dead code. Dead code is bad, regardless how trivial it is, as its never executed/tested. Given the current scheme, I also wonder whether we should just use chrome.runtime.setUninstallURL directly in unistall.js for simplicity. kzar 2015/12/12 10:25:40 Done. Show quoted text On 2015/12/12 00:31:09, Sebastian Noack wrote: > This is dead code. Dead code is bad, regardless how trivial it is, as its never > executed/tested. > > Given the current scheme, I also wonder whether we should just use > chrome.runtime.setUninstallURL directly in unistall.js for simplicity. Done.
223 })();	224 })();

OLD	NEW

« lib/uninstall.js ('K') | « metadata.safari ('k') | no next file » | no next file with comments »