Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: metadata.common

Issue 29332492: Issue 3269 - Display uninstallation page when uninstalled (Closed)
Left Patch Set: Create ext.setUninstallURL abstraction Created Dec. 9, 2015, 3:36 p.m.
Right Patch Set: Check the API exists before using it Created Dec. 15, 2015, 11:32 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « lib/uninstall.js ('k') | metadata.safari » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 [general] 1 [general]
2 version = 1.9.4 2 version = 1.9.4
3 backgroundScripts = ext/common.js 3 backgroundScripts = ext/common.js
4 ext/background.js 4 ext/background.js
5 lib/compat.js 5 lib/compat.js
6 lib/info.js 6 lib/info.js
7 lib/adblockplus.js 7 lib/adblockplus.js
8 lib/punycode.js 8 lib/punycode.js
9 lib/publicSuffixList.js 9 lib/publicSuffixList.js
10 lib/sha1.js 10 lib/sha1.js
11 lib/jsbn.js 11 lib/jsbn.js
12 lib/rsa.js 12 lib/rsa.js
13 webrequest.js 13 webrequest.js
14 messageResponder.js 14 messageResponder.js
15 popupBlocker.js 15 popupBlocker.js
16 background.js 16 background.js
17 ext/uninstall.js
18 testScripts = ../ext/common.js 17 testScripts = ../ext/common.js
19 ../ext/background.js 18 ../ext/background.js
20 ../lib/compat.js 19 ../lib/compat.js
21 ../lib/info.js 20 ../lib/info.js
22 ../lib/adblockplus.js 21 ../lib/adblockplus.js
23 ../lib/publicSuffixList.js 22 ../lib/publicSuffixList.js
24 ../lib/punycode.js 23 ../lib/punycode.js
25 ../lib/sha1.js 24 ../lib/sha1.js
26 ../lib/jsbn.js 25 ../lib/jsbn.js
27 ../lib/rsa.js 26 ../lib/rsa.js
28 ../webrequest.js 27 ../webrequest.js
29 common.js 28 common.js
30 tests/adblockplus.js 29 tests/adblockplus.js
31 tests/versionComparator.js 30 tests/versionComparator.js
32 tests/url.js 31 tests/url.js
33 tests/signatures.js 32 tests/signatures.js
34 tests/cssEscaping.js 33 tests/cssEscaping.js
35 permissions = http://*/* https://*/* 34 permissions = http://*/* https://*/*
36 35
37 [contentScripts] 36 [contentScripts]
38 document_start = ext/common.js ext/content.js include.preload.js 37 document_start = ext/common.js ext/content.js cssProperties.js include.preload.j s
39 document_end = include.postload.js 38 document_end = include.postload.js
40 39
41 [mapping] 40 [mapping]
41 cssProperties.js = adblockplus/chrome/content/cssProperties.js
42 ext/content.js = chrome/ext/content.js 42 ext/content.js = chrome/ext/content.js
43 ext/popup.js = chrome/ext/popup.js 43 ext/popup.js = chrome/ext/popup.js
44 ext/uninstall.js = chrome/ext/uninstall.js
45 subscriptions.xml = adblockplus/chrome/content/ui/subscriptions.xml 44 subscriptions.xml = adblockplus/chrome/content/ui/subscriptions.xml
46 firstRun.html = adblockplusui/firstRun.html 45 firstRun.html = adblockplusui/firstRun.html
47 common.js = adblockplusui/common.js 46 common.js = adblockplusui/common.js
48 firstRun.js = adblockplusui/firstRun.js 47 firstRun.js = adblockplusui/firstRun.js
49 i18n.js = adblockplusui/i18n.js 48 i18n.js = adblockplusui/i18n.js
50 messageResponder.js = adblockplusui/messageResponder.js 49 messageResponder.js = adblockplusui/messageResponder.js
51 icons/detailed/abp-128.png = adblockplusui/skin/abp-128.png 50 icons/detailed/abp-128.png = adblockplusui/skin/abp-128.png
52 skin/common.css = adblockplusui/skin/common.css 51 skin/common.css = adblockplusui/skin/common.css
53 skin/firstRun.css = adblockplusui/skin/firstRun.css 52 skin/firstRun.css = adblockplusui/skin/firstRun.css
54 skin/ajax-loader.gif = adblockplusui/skin/ajax-loader.gif 53 skin/ajax-loader.gif = adblockplusui/skin/ajax-loader.gif
(...skipping 19 matching lines...) Expand all
74 lib/adblockplus.js = lib/prefs.js 73 lib/adblockplus.js = lib/prefs.js
75 lib/utils.js 74 lib/utils.js
76 lib/io.js 75 lib/io.js
77 adblockplus/lib/downloader.js 76 adblockplus/lib/downloader.js
78 adblockplus/lib/filterNotifier.js 77 adblockplus/lib/filterNotifier.js
79 adblockplus/lib/filterClasses.js 78 adblockplus/lib/filterClasses.js
80 adblockplus/lib/subscriptionClasses.js 79 adblockplus/lib/subscriptionClasses.js
81 adblockplus/lib/filterStorage.js 80 adblockplus/lib/filterStorage.js
82 adblockplus/lib/elemHide.js 81 adblockplus/lib/elemHide.js
83 adblockplus/lib/matcher.js 82 adblockplus/lib/matcher.js
83 adblockplus/lib/cssRules.js
84 adblockplus/lib/filterListener.js 84 adblockplus/lib/filterListener.js
85 adblockplus/lib/synchronizer.js 85 adblockplus/lib/synchronizer.js
86 adblockplus/lib/notification.js 86 adblockplus/lib/notification.js
87 adblockplus/lib/antiadblockInit.js 87 adblockplus/lib/antiadblockInit.js
88 lib/url.js 88 lib/url.js
89 lib/stats.js 89 lib/stats.js
90 lib/whitelisting.js 90 lib/whitelisting.js
91 lib/filterValidation.js 91 lib/filterValidation.js
92 lib/filterComposer.js 92 lib/filterComposer.js
93 lib/icon.js 93 lib/icon.js
94 lib/notificationHelper.js 94 lib/notificationHelper.js
95 lib/uninstall.js
95 --arg module=true source_repo=https://hg.adblockplus.org/adblockplus/ 96 --arg module=true source_repo=https://hg.adblockplus.org/adblockplus/
96 ext/common.js = ext/common.js chrome/ext/common.js 97 ext/common.js = ext/common.js chrome/ext/common.js
97 ext/background.js = ext/background.js chrome/ext/background.js --arg brace_style =expand 98 ext/background.js = ext/background.js chrome/ext/background.js --arg brace_style =expand
98 99
99 qunit/tests/adblockplus.js = adblockplustests/chrome/content/tests/domainRestric tions.js 100 qunit/tests/adblockplus.js = adblockplustests/chrome/content/tests/domainRestric tions.js
100 adblockplustests/chrome/content/tests/filterClasses.js 101 adblockplustests/chrome/content/tests/filterClasses.js
101 adblockplustests/chrome/content/tests/filterNotifier.js 102 adblockplustests/chrome/content/tests/filterNotifier.js
102 adblockplustests/chrome/content/tests/filterStorage.js 103 adblockplustests/chrome/content/tests/filterStorage.js
103 adblockplustests/chrome/content/tests/matcher.js 104 adblockplustests/chrome/content/tests/matcher.js
104 adblockplustests/chrome/content/tests/prefs.js 105 adblockplustests/chrome/content/tests/prefs.js
105 adblockplustests/chrome/content/tests/regexpFilters_matching.js 106 adblockplustests/chrome/content/tests/regexpFilters_matching.js
106 adblockplustests/chrome/content/tests/subscriptionClasses.js 107 adblockplustests/chrome/content/tests/subscriptionClasses.js
107 --arg source_repo=https://hg.adblockplus.org/adblockplustests/ 108 --arg source_repo=https://hg.adblockplus.org/adblockplustests/
108 109
109 [import_locales] 110 [import_locales]
110 adblockplus/chrome/locale/*/global.properties = subscription_invalid_location 111 adblockplus/chrome/locale/*/global.properties = subscription_invalid_location
111 remove_subscription_warning 112 remove_subscription_warning
112 notification_antiadblock_title 113 notification_antiadblock_title
113 notification_antiadblock_message 114 notification_antiadblock_message
114 filter_elemhide_duplicate_id 115 filter_elemhide_duplicate_id
115 filter_elemhide_nocriteria 116 filter_elemhide_nocriteria
117 filter_cssproperty_nodomain
116 adblockplus/chrome/locale/*/overlay.dtd = hideplaceholders.label 118 adblockplus/chrome/locale/*/overlay.dtd = hideplaceholders.label
117 notification.button.yes 119 notification.button.yes
118 notification.button.no 120 notification.button.no
119 notification.closing.button.hide 121 notification.closing.button.hide
120 notification.closing.button.optout 122 notification.closing.button.optout
121 shownotifications.label 123 shownotifications.label
122 adblockplus/chrome/locale/*/filters.dtd = subscription.lastDownload.inProgress 124 adblockplus/chrome/locale/*/filters.dtd = subscription.lastDownload.inProgress
123 subscription.lastDownload.invalidURL 125 subscription.lastDownload.invalidURL
124 subscription.lastDownload.connectionError 126 subscription.lastDownload.connectionError
125 subscription.lastDownload.invalidData 127 subscription.lastDownload.invalidData
126 subscription.lastDownload.checksumMismatch 128 subscription.lastDownload.checksumMismatch
127 subscription.enabled.label 129 subscription.enabled.label
128 subscription.delete.label 130 subscription.delete.label
129 addSubscription.label 131 addSubscription.label
130 addSubscriptionAdd.label 132 addSubscriptionAdd.label
131 addSubscriptionOther.label 133 addSubscriptionOther.label
132 acceptableAds2.label 134 acceptableAds2.label
133 viewList.label 135 viewList.label
134 readMore.label 136 readMore.label
135 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label 137 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label
136 title.label 138 title.label
137 adblockplus/chrome/locale/*/meta.properties = =name 139 adblockplus/chrome/locale/*/meta.properties = =name
138 adblockplusui/locale/*/firstRun.json = =* 140 adblockplusui/locale/*/firstRun.json = =*
LEFTRIGHT

Powered by Google App Engine
This is Rietveld