Issue 3269 - Display uninstallation page when uninstalled

lib/uninstall.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 14 matching lines @@
 {
   let search = [];
   let keys = ["addonName", "addonVersion", "application", "applicationVersion",
               "platform", "platformVersion"];
   for (let key of keys)
     search.push(key + "=" + encodeURIComponent(info[key]));
 
   let downlCount = Prefs.notificationdata.downloadCount || 0;
   search.push("notificationDownloadCount=" + encodeURIComponent(downlCount));
 
   chrome.runtime.setUninstallURL(Utils.getDocLink("uninstalled") + "&" +

[Sebastian Noack, 2015/12/15 06:41:18]

How I could I miss that? Of course, we have to check for the existence of that
API before calling it for compatibility with older Chrome versions.

[kzar, 2015/12/15 11:34:16]

Done.

                                  search.join("&"));
 }
 
 function onPrefsLoaded()
 {
   Prefs.onLoaded.removeListener(onPrefsLoaded);
   setUninstallURL();
 }
 
 // The uninstall URL contains the notification download count as a parameter,
 // therefore we must wait for preferences to be loaded before generating the
 // URL and we need to re-generate it each time the notification data changes.
-Prefs.onLoaded.addListener(onPrefsLoaded);
-Prefs.onChanged.addListener(function(name)
+if ("setUninstallURL" in chrome.runtime)
 {
-  if (name == "notificationdata")
-    setUninstallURL();
-});
+  Prefs.onLoaded.addListener(onPrefsLoaded);
+  Prefs.onChanged.addListener(function(name)
+  {
+    if (name == "notificationdata")
+      setUninstallURL();
+  });
+}