Issue 3403 - Add web redirect for the uninstallation page

modules/web/templates/adblockplus.org.conf.erb

 # XSS and clickjacking prevention headers
 
 set $csp_frame "";
 if ($uri ~ ^/(:?\w\w(_\w\w)?/)?(?:index|firefox|chrome|opera|android|internet-explorer|safari|yandex-browser|maxthon)?$)
 {
   set $csp_frame "; frame-src www.youtube-nocookie.com;";
 }
 add_header Content-Security-Policy "default-src 'self'; img-src * data:; style-src 'self' 'unsafe-inline'; script-src 'self' 'unsafe-inline' 'unsafe-eval' $csp_frame";
 add_header X-Frame-Options "sameorigin";
 
@@ skipping 153 matching lines @@
 
   set $lang "en";
   set $link "";
   set $anchor "";
 
   if ($arg_link ~ "^share-")
   {
     set $link "share";
     set $anchor "?a=minimal";
   }
+  if ($arg_link ~ "uninstalled")

[Felix Dahlke, 2015/12/14 10:23:26]

Since you're not matching a regex, you can just use `=`.

[kzar, 2015/12/14 10:45:49]

Done.

+  {
+    set $link "uninstall-abp";
+  }
   if ($arg_link = "gettingStarted")
   {
     set $link "getting_started";
   }
   if ($arg_link = "faq")
   {
     set $link "faq";
   }
   if ($arg_link = "filterdoc")
   {
@@ skipping 49 matching lines @@
     set $lang "$1_$2";
   }
   if (!-f "$document_root/$lang/$link")
   {
     set $lang "en";
   }
   if ($link = "share")
   {
     rewrite ^ https://share.adblockplus.org/$lang/? redirect;
   }
+  if ($link = "uninstall-abp")
+  {
+    rewrite ^ /$lang/$link$anchor redirect;

[kzar, 2015/12/13 17:25:40]

This is required because we want to preserve query parameters and therefore
can't have the trailing `?`.

[Felix Dahlke, 2015/12/14 10:23:26]

So you mean, this:

https://adblockplus.org/redirect?link=uninstalled&foo=bar

would redirect to:

https://adblockplus.org/en/uninstall-abp?link=uninstalled&foo=bar

?

Assuming this works, IMO it deserves a comment. Also note that we won't need
$anchor here.

[kzar, 2015/12/14 10:45:49]

Yep, although we've just agreed in IRC to rename uninstall-abp to uninstalled so
I've updated it accordingly. (It does work, I've tested  it each time.)

[Felix Dahlke, 2015/12/14 11:21:16]

Awesome, I was about to suggest that, but didn't bother since the page was
already live :P

+  }
   rewrite ^ /$lang/$link$anchor? redirect;
 }
 
 location /devbuilds
 {
   rewrite ^(.*) https://downloads.adblockplus.org$1;
 }
 
 # Locations still served by the legacy server
 
@@ skipping 44 matching lines @@
 location /403.html
 {
   try_files $uri @proxied;
 }
 location @proxied
 {
   proxy_pass https://server16.adblockplus.org;
   proxy_set_header Host adblockplus.org;
   proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
 }