Issue 3403 - Add web redirect for the uninstallation page

modules/web/templates/adblockplus.org.conf.erb

Index: modules/web/templates/adblockplus.org.conf.erb
diff --git a/modules/web/templates/adblockplus.org.conf.erb b/modules/web/templates/adblockplus.org.conf.erb
index 8279f13e5b3bce72689764bdfbb2c5dfc71ad839..3dd11214cad6dada3d75016cc3f1ef20c40c0cac 100644
--- a/modules/web/templates/adblockplus.org.conf.erb
+++ b/modules/web/templates/adblockplus.org.conf.erb
@@ -171,6 +171,10 @@ location /redirect
     set $link "share";
     set $anchor "?a=minimal";
   }
+  if ($arg_link ~ "uninstalled")

[Felix Dahlke, 2015/12/14 10:23:26]

Since you're not matching a regex, you can just use `=`.

[kzar, 2015/12/14 10:45:49]

Done.

+  {
+    set $link "uninstall-abp";
+  }
   if ($arg_link = "gettingStarted")
   {
     set $link "getting_started";
@@ -240,6 +244,10 @@ location /redirect
   {
     rewrite ^ https://share.adblockplus.org/$lang/? redirect;
   }
+  if ($link = "uninstall-abp")
+  {
+    rewrite ^ /$lang/$link$anchor redirect;

[kzar, 2015/12/13 17:25:40]

This is required because we want to preserve query parameters and therefore
can't have the trailing `?`.

[Felix Dahlke, 2015/12/14 10:23:26]

So you mean, this:

https://adblockplus.org/redirect?link=uninstalled&foo=bar

would redirect to:

https://adblockplus.org/en/uninstall-abp?link=uninstalled&foo=bar

?

Assuming this works, IMO it deserves a comment. Also note that we won't need
$anchor here.

[kzar, 2015/12/14 10:45:49]

Yep, although we've just agreed in IRC to rename uninstall-abp to uninstalled so
I've updated it accordingly. (It does work, I've tested  it each time.)

[Felix Dahlke, 2015/12/14 11:21:16]

Awesome, I was about to suggest that, but didn't bother since the page was
already live :P

+  }
   rewrite ^ /$lang/$link$anchor? redirect;
 }