Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: pages/uninstalled.tmpl

Issue 29332615: Issue 3257 - Create uninstallation page in adblockplus.org (use GET http request) (Closed)
Left Patch Set: Use get instead of post, implement characters countdown Created Dec. 14, 2015, 1:47 p.m.
Right Patch Set: nit fix Created Dec. 14, 2015, 2:52 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | pages/uninstalled-submit.md » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 title=Adblock Plus has been uninstalled 1 title=Adblock Plus has been uninstalled
2 template=simple 2 template=simple
3 3
4 {% set reasons = [ 4 {% set reasons = [
5 ("1v0", "reason-not-installed", "I didn't install Adblock Plus."), 5 ("1v0", "reason-not-installed", "I didn't install Adblock Plus."),
6 ("2v0", "reason-slowing-down", "Adblock Plus slowed down my browser."), 6 ("2v0", "reason-slowing-down", "Adblock Plus slowed down my browser."),
7 ("3v0", "reason-acceptable-ads", "I don't like the Acceptable Ads program."), 7 ("3v0", "reason-acceptable-ads", "I don't like the Acceptable Ads program."),
8 ("4v0", "reason-see-ads", "Adblock Plus didn't block all ads."), 8 ("4v0", "reason-see-ads", "Adblock Plus didn't block all ads."),
9 ("5v0", "reason-better-adblocker", "I found better ad blocking software."), 9 ("5v0", "reason-better-adblocker", "I found better ad blocking software."),
10 ("6v0", "reason-break-websites", "Adblock Plus breaks websites that I visit.") 10 ("6v0", "reason-break-websites", "Adblock Plus breaks websites that I visit.")
(...skipping 10 matching lines...) Expand all
21 21
22 // Create hidden input for GET parameters 22 // Create hidden input for GET parameters
23 window.location.search.substr(1).split("&").forEach(function(param) 23 window.location.search.substr(1).split("&").forEach(function(param)
24 { 24 {
25 if (!/.=./.test(param)) 25 if (!/.=./.test(param))
26 return; 26 return;
27 27
28 var paramSplit = param.split("="); 28 var paramSplit = param.split("=");
29 var input = document.createElement("input"); 29 var input = document.createElement("input");
30 input.setAttribute("type", "hidden"); 30 input.setAttribute("type", "hidden");
31 input.setAttribute("name", paramSplit[0]); 31 input.setAttribute("name", decodeURIComponent(paramSplit[0]));
32 input.setAttribute("value", decodeURIComponent(paramSplit[1])); 32 input.setAttribute("value", decodeURIComponent(paramSplit[1]));
33 form.appendChild(input); 33 form.appendChild(input);
34 }); 34 });
35 35
36 // Randomly add reasons 36 // Randomly add reasons
37 var reasonsContainer = document.getElementById("reasons"); 37 var reasonsContainer = document.getElementById("reasons");
38 var reasons = reasonsContainer.getElementsByTagName("li"); 38 var reasons = reasonsContainer.getElementsByTagName("li");
39 reasons = Array.prototype.slice.call(reasons); 39 reasons = Array.prototype.slice.call(reasons);
40 reasonsContainer.innerHTML = ""; 40 reasonsContainer.innerHTML = "";
41 while (reasons.length) 41 while (reasons.length)
42 { 42 {
43 var randomIndex = Math.floor(Math.random() * (reasons.length -1)); 43 var randomIndex = Math.floor(Math.random() * (reasons.length -1));
44 var reasonElement = reasons.splice(randomIndex, 1)[0]; 44 var reasonElement = reasons.splice(randomIndex, 1)[0];
45 reasonsContainer.appendChild(reasonElement); 45 reasonsContainer.appendChild(reasonElement);
46 } 46 }
47 47
48 var reasonOtherCheckbox = document.getElementById("reason-other"); 48 var reasonOtherCheckbox = document.getElementById("reason-other");
49 var reasonOther = document.getElementById("reason-other-container");
49 reasonOtherCheckbox.addEventListener("change", function() 50 reasonOtherCheckbox.addEventListener("change", function()
50 { 51 {
51 var reasonOther = document.getElementById("reason-other-container"); 52 reasonOther.classList.toggle("hidden");
52 if (reasonOther.hasAttribute("class"))
53 reasonOther.removeAttribute("class")
Sebastian Noack 2015/12/14 14:16:34 How about using |.classList.toggle("hidden")|?
saroyanm 2015/12/14 14:48:12 Done.
54 else
55 reasonOther.setAttribute("class", "hidden");
56 }, false); 53 }, false);
57 54
58 var reasonOtherInput = document.getElementById("reason-other-input"); 55 var reasonOtherInput = document.getElementById("reason-other-input");
59 var maxLength = reasonOtherInput.getAttribute("maxlength"); 56 var maxLength = reasonOtherInput.getAttribute("maxlength");
60 var charCounter = document.getElementById("characters-countdown"); 57 var charCounter = document.getElementById("characters-countdown");
61 charCounter.textContent = maxLength; 58 charCounter.textContent = maxLength;
62 reasonOtherInput.addEventListener("keyup", function() 59 reasonOtherInput.addEventListener("keyup", function()
63 { 60 {
64 charCounter.textContent = maxLength - reasonOtherInput.value.length; 61 charCounter.textContent = maxLength - reasonOtherInput.value.length;
65 }, false); 62 }, false);
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 </div> 106 </div>
110 </li> 107 </li>
111 </ul> 108 </ul>
112 <button id="submit-form">{{"Submit"|translate("submit", "Submit button text" )}}</button> 109 <button id="submit-form">{{"Submit"|translate("submit", "Submit button text" )}}</button>
113 <span class="error-label">{{"Please select at least one of the options above "|translate("error-msg", "Error message, is being shown after submission if no i tem selected")}}</span> 110 <span class="error-label">{{"Please select at least one of the options above "|translate("error-msg", "Error message, is being shown after submission if no i tem selected")}}</span>
114 </form> 111 </form>
115 <p class="disclaimer"> 112 <p class="disclaimer">
116 {{"By clicking Submit, you are sending your response to Adblock Plus. Please see our <a href='/privacy'>privacy policy</a>."|translate("disclaimer", "Discla imer below form")}} 113 {{"By clicking Submit, you are sending your response to Adblock Plus. Please see our <a href='/privacy'>privacy policy</a>."|translate("disclaimer", "Discla imer below form")}}
117 </p> 114 </p>
118 </section> 115 </section>
LEFTRIGHT

Powered by Google App Engine
This is Rietveld