Issue #1234 - Remove 'CString' From 'ToLowerString()'

test/plugin/UtilTest.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 53 matching lines @@
 
 TEST(BeginsWith, ExtraBad)
 {
   ASSERT_FALSE(BeginsWithForTesting(L"foo", L"foobar"));
 }
 
 TEST(BeginsWith, LongerBad)
 {
   ASSERT_FALSE(BeginsWithForTesting(L"foo", L"barfoo"));
 }
+
+TEST(ToLowerString, Empty)
+{
+  ASSERT_EQ(L"", ToLowerString(L""));
+}
+
+TEST(ToLowerString, NotEmpty)
+{
+  ASSERT_EQ(L"foo", ToLowerString(L"Foo"));
+}
+
+TEST(ToLowerString, NullWithExtra)
+{
+  std::wstring input(L"\0BAR", 4);
+  ASSERT_EQ(4, input.length());
+
+  std::wstring actual;
+  ASSERT_NO_THROW({ actual = ToLowerString(input); });
+  // White-box tests for further verification of no-crash behavior
+  ASSERT_EQ(4, actual.length());
+  ASSERT_EQ(L"", std::wstring(actual.c_str()));

[sergei, 2015/12/16 15:53:16]

That looks strange, it's good to know what happened with "BAR"?

[Eric, 2015/12/16 16:38:07]

Don't need to know. The (new) specification for the function only says that it
returns, and with an undefined result. I'm only checking the result here because
I have white-box access, and it's a way of ensuring the function doesn't do
anything harmful for its undefined result. That's why these are labelled
"white-box"; they're cheating the black-box principle of ordinary unit testing
to verify a behavior (not crashing or harming otherwise) that's hard to check
directly.

Also, what happens to "BAR" differs between Debug and Release. The debug version
of the '*_s' functions fill the buffer with a dummy character and the release
version doesn't. No need to bother with that. I just left it out.

+}
+
+TEST(ToLowerString, InternalNull)
+{
+  std::wstring input(L"Foo\0BAR", 7);
+  ASSERT_EQ(7, input.length());
+
+  std::wstring actual;
+  ASSERT_NO_THROW({ actual = ToLowerString(input); });
+  // White-box tests for further verification of no-crash behavior
+  ASSERT_EQ(7, actual.length());
+  ASSERT_EQ(L"foo", std::wstring(actual.c_str()));
+}