Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: src/plugin/PluginUtil.h

Issue 29332775: Issue #1234 - Remove 'CString' From 'ToLowerString()' (Closed)
Left Patch Set: Created Dec. 15, 2015, 9:10 p.m.
Right Patch Set: address comments, round two Created Jan. 7, 2016, 2:32 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | src/plugin/PluginUtil.cpp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2015 Eyeo GmbH 3 * Copyright (C) 2006-2015 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 15 matching lines...) Expand all
26 std::wstring GetLocationUrl(IWebBrowser2& browser); 26 std::wstring GetLocationUrl(IWebBrowser2& browser);
27 27
28 template<class CharT, class Traits, class Alloc, size_t N> 28 template<class CharT, class Traits, class Alloc, size_t N>
29 bool BeginsWith(const std::basic_string<CharT, Traits, Alloc>& s, const CharT(&b eginning)[N]) 29 bool BeginsWith(const std::basic_string<CharT, Traits, Alloc>& s, const CharT(&b eginning)[N])
30 { 30 {
31 return 0 == s.compare(0, N - 1, beginning); 31 return 0 == s.compare(0, N - 1, beginning);
32 } 32 }
33 33
34 /** 34 /**
35 * Return a lower-case version of the argument string. 35 * Return a lower-case version of the argument string.
36 * Collates according to the current locale. 36 * Lowers case according to the current locale.
sergei 2015/12/16 10:32:45 That seems to be correct choice. We can also creat
Eric 2015/12/16 13:53:26 For my purposes in this change set, it's the choic
37 * May not lower-case entire string if it contains embedded null characters. 37 * This function has an undefined return value if the argument string contains e mbedded null characters.
sergei 2015/12/16 10:32:45 I know that it can theoretically happen, especiall
Eric 2015/12/16 13:53:26 I don't think we ever have a situation where we'll
38 */ 38 */
39 std::wstring ToLowerString(const std::wstring& s); 39 std::wstring ToLowerString(const std::wstring& s);
LEFTRIGHT

Powered by Google App Engine
This is Rietveld