Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: src/plugin/PluginUtil.cpp

Issue 29332775: Issue #1234 - Remove 'CString' From 'ToLowerString()' (Closed)
Left Patch Set: address comments Created Dec. 16, 2015, 4:35 p.m.
Right Patch Set: address comments, round two Created Jan. 7, 2016, 2:32 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « src/plugin/PluginUtil.h ('k') | test/plugin/UtilTest.cpp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2015 Eyeo GmbH 3 * Copyright (C) 2006-2015 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 { 50 {
51 return std::wstring(); 51 return std::wstring();
52 } 52 }
53 return std::wstring(locationUrl, locationUrl.Length()); 53 return std::wstring(locationUrl, locationUrl.Length());
54 } 54 }
55 55
56 std::wstring ToLowerString(const std::wstring& s) 56 std::wstring ToLowerString(const std::wstring& s)
57 { 57 {
58 std::wstring lower(s); // Copy the argument 58 std::wstring lower(s); // Copy the argument
59 /* 59 /*
60 * C++11 provides that 'c_str()' returns the internal array in which the strin g holds its value.
61 * Thus we can modify in-place after casting away the 'const' modifier from 'c _str()'.
62 *
63 * Documentation for '_wcslwr_s' https://msdn.microsoft.com/en-us/library/y889 wzfw.aspx 60 * Documentation for '_wcslwr_s' https://msdn.microsoft.com/en-us/library/y889 wzfw.aspx
64 * This documentation is incorrect on an important point. 61 * This documentation is incorrect on an important point.
65 * Regarding parameter validation, it says "length of string" where it should say "length of buffer". 62 * Regarding parameter validation, it says "length of string" where it should say "length of buffer".
66 * The call below has argument "length + 1" to include the terminating null ch aracter in the buffer. 63 * The call below has argument "length + 1" to include the terminating null ch aracter in the buffer.
67 */ 64 */
68 auto e = _wcslwr_s(const_cast<wchar_t*>(lower.c_str()), lower.length() + 1); / / uses the current locale 65 auto e = _wcslwr_s(const_cast<wchar_t*>(lower.c_str()), lower.length() + 1); / / uses the current locale
69 if (e != 0) 66 if (e != 0)
70 { 67 {
71 throw std::logic_error("Error code returned from _wcslwr_s()"); 68 throw std::logic_error("Error code returned from _wcslwr_s()");
72 } 69 }
73 return lower; 70 return lower;
74 } 71 }
75 72
LEFTRIGHT

Powered by Google App Engine
This is Rietveld