src/plugin/PluginUtil.h - Issue 29332775: Issue #1234 - Remove 'CString' From 'ToLowerString()'

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/plugin/PluginUtil.h

Issue 29332775: Issue #1234 - Remove 'CString' From 'ToLowerString()' (Closed)

Patch Set: rewrite to use _wcslwr_s() Created Dec. 16, 2015, 1:51 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: src/plugin/PluginUtil.h

===================================================================

--- a/src/plugin/PluginUtil.h

+++ b/src/plugin/PluginUtil.h

@@ -33,6 +33,7 @@

/**

* Return a lower-case version of the argument string.

- * Current version uses 'CString::MakeLower()' to preserve legacy behavior during refactoring.

+ * Lowers case according to the current locale.

+ * This function has an undefined return value if the argument string contains embedded null characters.

std::wstring ToLowerString(const std::wstring& s);

« no previous file with comments | « no previous file | src/plugin/PluginUtil.cpp » ('j') | src/plugin/PluginUtil.cpp » ('J')