Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Delta Between Two Patch Sets: options.html

Issue 29332808: Issue 2408 - Improved accessibility of checkboxes in options page (Closed)
Left Patch Set: Created Dec. 16, 2015, 1:31 p.m.
Right Patch Set: Reverted styles for Advanced tab Created Jan. 25, 2016, 6:02 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | options.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 - This file is part of Adblock Plus <https://adblockplus.org/>, 3 - This file is part of Adblock Plus <https://adblockplus.org/>,
4 - Copyright (C) 2006-2015 Eyeo GmbH 4 - Copyright (C) 2006-2015 Eyeo GmbH
5 - 5 -
6 - Adblock Plus is free software: you can redistribute it and/or modify 6 - Adblock Plus is free software: you can redistribute it and/or modify
7 - it under the terms of the GNU General Public License version 3 as 7 - it under the terms of the GNU General Public License version 3 as
8 - published by the Free Software Foundation. 8 - published by the Free Software Foundation.
9 - 9 -
10 - Adblock Plus is distributed in the hope that it will be useful, 10 - Adblock Plus is distributed in the hope that it will be useful,
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 <span class="icon"></span> 64 <span class="icon"></span>
65 </li> 65 </li>
66 <li id="tab-contribute"> 66 <li id="tab-contribute">
67 <a class="i18n_options_tab_contribute"></a> 67 <a class="i18n_options_tab_contribute"></a>
68 <span class="icon"></span> 68 <span class="icon"></span>
69 </li> 69 </li>
70 </ul> 70 </ul>
71 </footer> 71 </footer>
72 </div> 72 </div>
73 </div> 73 </div>
74 <div id="tab-content"> 74 <div id="content">
75 <div id="content-wrapper"> 75 <div id="content-wrapper">
76 <div id="dialog-background"></div> 76 <div id="dialog-background"></div>
77 77
78 <!-- General tab content --> 78 <!-- General tab content -->
79 <div id="content-general" class="tab-content"> 79 <div id="content-general" class="tab-content">
80 <div> 80 <div>
81 <h1 class="i18n_options_blocking_title"></h1> 81 <h1 class="i18n_options_blocking_title"></h1>
82 <div class="hbox"> 82 <div class="hbox">
83 <div id="blocking-languages"> 83 <div id="blocking-languages">
84 <div class="option-name"> 84 <div class="option-name">
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 </div> 181 </div>
182 </div> 182 </div>
183 </div> 183 </div>
184 <ul id="whitelisting-table" class="table list"> 184 <ul id="whitelisting-table" class="table list">
185 <template> 185 <template>
186 <button class="delete control"></button> 186 <button class="delete control"></button>
187 <span class="display"></span> 187 <span class="display"></span>
188 </template> 188 </template>
189 </ul> 189 </ul>
190 <div class="controls"> 190 <div class="controls">
191 <button data-action="edit-domain-exception">
192 <span class="icon icon-add"></span>
193 <span class="i18n_options_whitelisted_add"></span>
194 </button>
191 <div> 195 <div>
192 <span class="icon icon-add" data-action="add-domain-exceptio n"></span> 196 <span class="icon icon-add" data-action="add-domain-exceptio n"></span>
193 <input type="text" id="whitelisting-textbox" /> 197 <input type="text" id="whitelisting-textbox" placeholder="ww w.example.com" />
194 <span class="icon icon-enter" data-action="add-domain-except ion"></span> 198 <span class="icon icon-enter" data-action="add-domain-except ion"></span>
195 </div> 199 </div>
196 <div> 200 <div>
197 <button id="whitelisting-add-button" class="button-add" data -action="add-domain-exception"> 201 <button id="whitelisting-add-button" class="button-add" data -action="add-domain-exception">
198 +<span class="i18n_options_button_add"></span> 202 +<span class="i18n_options_button_add"></span>
199 </button> 203 </button>
200 <span></span> 204 <span></span>
201 <button class="i18n_options_button_cancel cancel-button" dat a-action="cancel-domain-exception"></button> 205 <button class="i18n_options_button_cancel cancel-button" dat a-action="cancel-domain-exception"></button>
202 </div> 206 </div>
203 </div> 207 </div>
(...skipping 15 matching lines...) Expand all
219 </div> 223 </div>
220 <div> 224 <div>
221 <h1><span class="i18n_options_blockingList_title"></span><a class="i 18n_options_readMore tooltip" href="#" target="_blank"></a></h1> 225 <h1><span class="i18n_options_blockingList_title"></span><a class="i 18n_options_readMore tooltip" href="#" target="_blank"></a></h1>
222 <ul id="blocking-list-tabs" class="tabs horizontal"> 226 <ul id="blocking-list-tabs" class="tabs horizontal">
223 <li class="i18n_options_tab_overview active" data-show="blocking-l ist-overview"></li><li class="i18n_options_tab_ownList" data-show="custom-filter s"></li> 227 <li class="i18n_options_tab_overview active" data-show="blocking-l ist-overview"></li><li class="i18n_options_tab_ownList" data-show="custom-filter s"></li>
224 </ul> 228 </ul>
225 <div id="blocking-list"> 229 <div id="blocking-list">
226 <div id="blocking-list-overview"> 230 <div id="blocking-list-overview">
227 <ul class="table cols" style="width: auto;"> 231 <ul class="table cols" style="width: auto;">
228 <li class="col-name"><span class="i18n_options_tableCol_name"> </span><span class="i18n_options_tableCol_description"></span><span class="i18n_ options_tableCol_date"></span></li> 232 <li class="col-name"><span class="i18n_options_tableCol_name"> </span><span class="i18n_options_tableCol_description"></span><span class="i18n_ options_tableCol_date"></span></li>
229 <li> 233 <li><input type="checkbox" id="easylist"/><span>Easylist</span ><span>Adblocking english sites</span><span>15 March 14 - 10:31</span></li>
230 <button role="checkbox" id="easylist"></button> 234 <li><input type="checkbox" id="easylist+de"/><span>Easylist Ge rmany + Easylist</span><span>Adblocking english + german sites</span><span>15 Ma rch 14 - 10:31</span></li>
231 <span>Easylist</span> 235 <li><input type="checkbox" id="annoyance-fb"/><span>Facebook a nnoyance blocker</span><span>Blocks Facebook annoyances</span><span>15 March 14 - 10:31</span></li>
232 <span>Adblocking english sites</span> 236 <li><input type="checkbox" id="annoyance-youtube"/><span>Faceb ook annoyance blocker</span><span>Blocks Facebook annoyances</span><span>15 Marc h 14 - 10:31</span></li>
233 <span>15 March 14 - 10:31</span> 237 <li><input type="checkbox" id="own-list"/><span>Own blocking l ist</span><span>Your own blocking list</span><span><a href="#">edit your blockin g list</a></span></li>
234 </li>
235 <li>
236 <button role="checkbox" id="easylist+de"></button>
237 <span>Easylist Germany + Easylist</span>
238 <span>Adblocking english + german sites</span>
239 <span>15 March 14 - 10:31</span>
240 </li>
241 <li>
242 <button role="checkbox" id="annoyance-fb"></button>
243 <span>Facebook annoyance blocker</span>
244 <span>Blocks Facebook annoyances</span>
245 <span>15 March 14 - 10:31</span>
246 </li>
247 <li>
248 <button role="checkbox" id="annoyance-youtube"></button>
249 <span>Facebook annoyance blocker</span>
250 <span>Blocks Facebook annoyances</span>
251 <span>15 March 14 - 10:31</span>
252 </li>
253 <li>
254 <button role="checkbox" id="own-list"></button>
255 <span>Own blocking list</span>
256 <span>Your own blocking list</span>
257 <span><a href="#">edit your blocking list</a></span>
258 </li>
259 </ul> 238 </ul>
260 <div class="controls"> 239 <div class="controls">
261 <button> 240 <button>
262 <span class="icon icon-add"></span><span class="i18n_options _blockingList_add"></span> 241 <span class="icon icon-add"></span><span class="i18n_options _blockingList_add"></span>
263 </button> 242 </button>
264 <button> 243 <button>
265 <span class="icon icon-update"></span><span class="i18n_opti ons_blockingList_update"></span> 244 <span class="icon icon-update"></span><span class="i18n_opti ons_blockingList_update"></span>
266 </button> 245 </button>
267 </div> 246 </div>
268 </div> 247 </div>
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
383 <div class="url"></div> 362 <div class="url"></div>
384 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button> 363 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button>
385 </div> 364 </div>
386 </div> 365 </div>
387 </div> 366 </div>
388 <!-- Placeholder element to determine when to wrap focus around --> 367 <!-- Placeholder element to determine when to wrap focus around -->
389 <span class="focus-last" tabindex="0"></span> 368 <span class="focus-last" tabindex="0"></span>
390 </div> 369 </div>
391 </body> 370 </body>
392 </html> 371 </html>
LEFTRIGHT
« no previous file | options.js » ('j') | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld