Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Delta Between Two Patch Sets: options.html

Issue 29332808: Issue 2408 - Improved accessibility of checkboxes in options page (Closed)
Left Patch Set: Rebased to 59920e6112a6 Created Dec. 17, 2015, 6:36 p.m.
Right Patch Set: Reverted styles for Advanced tab Created Jan. 25, 2016, 6:02 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | options.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 - This file is part of Adblock Plus <https://adblockplus.org/>, 3 - This file is part of Adblock Plus <https://adblockplus.org/>,
4 - Copyright (C) 2006-2015 Eyeo GmbH 4 - Copyright (C) 2006-2015 Eyeo GmbH
5 - 5 -
6 - Adblock Plus is free software: you can redistribute it and/or modify 6 - Adblock Plus is free software: you can redistribute it and/or modify
7 - it under the terms of the GNU General Public License version 3 as 7 - it under the terms of the GNU General Public License version 3 as
8 - published by the Free Software Foundation. 8 - published by the Free Software Foundation.
9 - 9 -
10 - Adblock Plus is distributed in the hope that it will be useful, 10 - Adblock Plus is distributed in the hope that it will be useful,
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 <span class="icon"></span> 64 <span class="icon"></span>
65 </li> 65 </li>
66 <li id="tab-contribute"> 66 <li id="tab-contribute">
67 <a class="i18n_options_tab_contribute"></a> 67 <a class="i18n_options_tab_contribute"></a>
68 <span class="icon"></span> 68 <span class="icon"></span>
69 </li> 69 </li>
70 </ul> 70 </ul>
71 </footer> 71 </footer>
72 </div> 72 </div>
73 </div> 73 </div>
74 <div id="tab-content"> 74 <div id="content">
saroyanm 2016/01/19 11:19:49 Detail: I think this can become tabs-content for r
Thomas Greiner 2016/01/19 15:15:04 Done. For consistency I chose to go with "content"
75 <div id="content-wrapper"> 75 <div id="content-wrapper">
76 <div id="dialog-background"></div> 76 <div id="dialog-background"></div>
77 77
78 <!-- General tab content --> 78 <!-- General tab content -->
79 <div id="content-general" class="tab-content"> 79 <div id="content-general" class="tab-content">
80 <div> 80 <div>
81 <h1 class="i18n_options_blocking_title"></h1> 81 <h1 class="i18n_options_blocking_title"></h1>
82 <div class="hbox"> 82 <div class="hbox">
83 <div id="blocking-languages"> 83 <div id="blocking-languages">
84 <div class="option-name"> 84 <div class="option-name">
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 </div> 223 </div>
224 <div> 224 <div>
225 <h1><span class="i18n_options_blockingList_title"></span><a class="i 18n_options_readMore tooltip" href="#" target="_blank"></a></h1> 225 <h1><span class="i18n_options_blockingList_title"></span><a class="i 18n_options_readMore tooltip" href="#" target="_blank"></a></h1>
226 <ul id="blocking-list-tabs" class="tabs horizontal"> 226 <ul id="blocking-list-tabs" class="tabs horizontal">
227 <li class="i18n_options_tab_overview active" data-show="blocking-l ist-overview"></li><li class="i18n_options_tab_ownList" data-show="custom-filter s"></li> 227 <li class="i18n_options_tab_overview active" data-show="blocking-l ist-overview"></li><li class="i18n_options_tab_ownList" data-show="custom-filter s"></li>
228 </ul> 228 </ul>
229 <div id="blocking-list"> 229 <div id="blocking-list">
230 <div id="blocking-list-overview"> 230 <div id="blocking-list-overview">
231 <ul class="table cols" style="width: auto;"> 231 <ul class="table cols" style="width: auto;">
232 <li class="col-name"><span class="i18n_options_tableCol_name"> </span><span class="i18n_options_tableCol_description"></span><span class="i18n_ options_tableCol_date"></span></li> 232 <li class="col-name"><span class="i18n_options_tableCol_name"> </span><span class="i18n_options_tableCol_description"></span><span class="i18n_ options_tableCol_date"></span></li>
233 <li> 233 <li><input type="checkbox" id="easylist"/><span>Easylist</span ><span>Adblocking english sites</span><span>15 March 14 - 10:31</span></li>
saroyanm 2016/01/19 11:19:49 This will be changed with blocking list implementa
Thomas Greiner 2016/01/19 15:15:04 Done.
234 <button role="checkbox" id="easylist"></button> 234 <li><input type="checkbox" id="easylist+de"/><span>Easylist Ge rmany + Easylist</span><span>Adblocking english + german sites</span><span>15 Ma rch 14 - 10:31</span></li>
235 <span>Easylist</span> 235 <li><input type="checkbox" id="annoyance-fb"/><span>Facebook a nnoyance blocker</span><span>Blocks Facebook annoyances</span><span>15 March 14 - 10:31</span></li>
236 <span>Adblocking english sites</span> 236 <li><input type="checkbox" id="annoyance-youtube"/><span>Faceb ook annoyance blocker</span><span>Blocks Facebook annoyances</span><span>15 Marc h 14 - 10:31</span></li>
237 <span>15 March 14 - 10:31</span> 237 <li><input type="checkbox" id="own-list"/><span>Own blocking l ist</span><span>Your own blocking list</span><span><a href="#">edit your blockin g list</a></span></li>
238 </li>
239 <li>
240 <button role="checkbox" id="easylist+de"></button>
241 <span>Easylist Germany + Easylist</span>
242 <span>Adblocking english + german sites</span>
243 <span>15 March 14 - 10:31</span>
244 </li>
245 <li>
246 <button role="checkbox" id="annoyance-fb"></button>
247 <span>Facebook annoyance blocker</span>
248 <span>Blocks Facebook annoyances</span>
249 <span>15 March 14 - 10:31</span>
250 </li>
251 <li>
252 <button role="checkbox" id="annoyance-youtube"></button>
253 <span>Facebook annoyance blocker</span>
254 <span>Blocks Facebook annoyances</span>
255 <span>15 March 14 - 10:31</span>
256 </li>
257 <li>
258 <button role="checkbox" id="own-list"></button>
259 <span>Own blocking list</span>
260 <span>Your own blocking list</span>
261 <span><a href="#">edit your blocking list</a></span>
262 </li>
263 </ul> 238 </ul>
264 <div class="controls"> 239 <div class="controls">
265 <button> 240 <button>
266 <span class="icon icon-add"></span><span class="i18n_options _blockingList_add"></span> 241 <span class="icon icon-add"></span><span class="i18n_options _blockingList_add"></span>
267 </button> 242 </button>
268 <button> 243 <button>
269 <span class="icon icon-update"></span><span class="i18n_opti ons_blockingList_update"></span> 244 <span class="icon icon-update"></span><span class="i18n_opti ons_blockingList_update"></span>
270 </button> 245 </button>
271 </div> 246 </div>
272 </div> 247 </div>
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
387 <div class="url"></div> 362 <div class="url"></div>
388 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button> 363 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button>
389 </div> 364 </div>
390 </div> 365 </div>
391 </div> 366 </div>
392 <!-- Placeholder element to determine when to wrap focus around --> 367 <!-- Placeholder element to determine when to wrap focus around -->
393 <span class="focus-last" tabindex="0"></span> 368 <span class="focus-last" tabindex="0"></span>
394 </div> 369 </div>
395 </body> 370 </body>
396 </html> 371 </html>
LEFTRIGHT
« no previous file | options.js » ('j') | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld