Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: options.html

Issue 29332808: Issue 2408 - Improved accessibility of checkboxes in options page (Closed)
Patch Set: Reverted styles for Advanced tab Created Jan. 25, 2016, 6:02 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | options.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: options.html
===================================================================
--- a/options.html
+++ b/options.html
@@ -71,12 +71,12 @@
</footer>
</div>
</div>
- <div id="tab-content">
+ <div id="content">
<div id="content-wrapper">
<div id="dialog-background"></div>
<!-- General tab content -->
- <div id="content-general">
+ <div id="content-general" class="tab-content">
<div>
<h1 class="i18n_options_blocking_title"></h1>
<div class="hbox">
@@ -97,7 +97,7 @@
</div>
<ul id="blocking-languages-table" class="table list">
<template>
- <input type="checkbox" class="control" />
+ <button role="checkbox" class="control"></button>
<span class="display"></span>
</template>
</ul>
@@ -122,14 +122,14 @@
<div id="custom-wrapper">
<ul id="recommend-list-table" class="table list">
<template>
- <input type="checkbox" class="control" />
+ <button role="checkbox" class="control"></button>
<span class="display"></span>
<span class="popular"></span>
</template>
</ul>
<ul id="custom-list-table" class="table list">
<template>
- <input type="checkbox" class="control" />
+ <button role="checkbox" class="control"></button>
<span class="display"></span>
</template>
</ul>
@@ -161,7 +161,7 @@
</div>
<ul id="acceptableads-table" class="table list">
<template>
- <input type="checkbox" class="control" />
+ <button role="checkbox" class="control"></button>
<span class="display"></span>
</template>
</ul>
@@ -211,12 +211,14 @@
</div>
<!-- Advanced tab content -->
- <div id="content-advanced">
+ <div id="content-advanced" class="tab-content">
<div>
<h1><span class="i18n_options_tweaks_title"></span><a class="i18n_options_readMore tooltip" href="#"></a></h1>
<ul class="table" style="width: auto;">
<li>
- <input type="checkbox" id="easylist"/><span id="block-element-explanation" class="i18n_options_tweaks_blockElement"></span></li>
+ <button role="checkbox" id="easylist"></button>
+ <span id="block-element-explanation" class="i18n_options_tweaks_blockElement"></span>
+ </li>
</ul>
</div>
<div>
@@ -281,7 +283,7 @@
</div>
<!-- Help tab content -->
- <div id="content-help">
+ <div id="content-help" class="tab-content">
<h1 class="i18n_options_faq_title"></h1>
<p class="i18n_options_faq_description"></p>
<p>
« no previous file with comments | « no previous file | options.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld