Issue 3435 - strip "index" from page path for canonical URL

filters/stripindex.py

+def stripindex(path):
+  if path.endswith("index"):
+    return path[:-5]

[Wladimir Palant, 2015/12/18 10:58:15]

This logic is wrong - imagine a page called fooindex.

I think it should be something along the lines of:

  parts = path.split("/")
  if parts[-1] == "index":
    parts.pop()
  return "/".join(parts)

[saroyanm, 2015/12/18 11:10:15]

Ahh right.

[Wladimir Palant, 2015/12/18 11:13:44]

In fact, given that this logic is only necessary in exactly one place, maybe it
is better to put it directly into the template:

  {# Drop "index" at the end of page path #}
  {% set canonical = page.split("/") %}
  {% if canonical[-1] == "index" %}
    {% set _ = canonical.pop() %}
  {% endif %}
  <link rel="canonical" href="https://adblockplus.org/{{ canonical|join("/")}}">

[saroyanm, 2015/12/18 11:24:18]

IMO it will affect readability of template file, I think this implementation
doesn't belong to template. I'd vote for keeping it separate, but will move to
template if you insist.

[Wladimir Palant, 2015/12/18 11:58:31]

Fair enough.

+  return path
+