Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: filters/stripindex.py
Issue
29332874
:
Issue 3435 - strip "index" from page path for canonical URL (Closed)
Patch Set: Went with Wladimir suggestion
Created Dec. 18, 2015, 11:08 a.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Went with Wladimir suggestion
Right:
Patch Set 1: None
Patch Set 2: Went with Wladimir suggestion
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
filters/stripindex.py
templates/default.tmpl
View unified diff
|
Download patch
« no previous file with comments
|
« no previous file
|
templates/default.tmpl »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
def stripindex(path):
2
parts = path.split("/")
3
if parts[-1] == "index":
4
parts.pop()
5
return "/".join(parts)
OLD
NEW
« no previous file with comments
|
« no previous file
|
templates/default.tmpl »
('j') |
no next file with comments »
Edit Message
Issue 29332874: Issue 3435 - strip "index" from page path for canonical URL (Closed)
Created Dec. 18, 2015, 10:28 a.m. by saroyanm
Modified Dec. 18, 2015, 12:56 p.m.
Reviewers: Sebastian Noack, Wladimir Palant
Base URL:
Comments: 5
This is Rietveld