Issue 3443 - Use process script instead of a frame script in Element Hiding Helper

lib/aardvark.js

 /*
  * This Source Code is subject to the terms of the Mozilla Public License
  * version 2.0 (the "License"). You can obtain a copy of the License at
  * http://mozilla.org/MPL/2.0/.
  */
 
 let {Prefs} = require("prefs");
 
 // Make sure to stop selection when we are uninstalled
 onShutdown.add(() => Aardvark.quit());
@@ skipping 571 matching lines @@
     this.browser = null;
     this.commentElem = null;
     this.lockedAnchor = null;
     this.boxElem = null;
     E = id => null;
     return false;
   },
 
   select: function(elem)
   {
-    if (!elem)
+    if (!elem || !this.window)

[saroyanm, 2015/12/21 16:48:55]

Not sure how this fix is related to current issue.

[Wladimir Palant, 2015/12/21 19:14:15]

I guess it's not. This merely silences an exception that came up while testing -
this code path would be entered again after selection was already canceled.
Creating a separate issue seems to be quite a bit of overhead for this.

       return false;
 
-    let browser = this.browser;
-    if ("selectedBrowser" in browser)  // tabbrowser element
-      browser = browser.selectedBrowser;
-
+    let messageManager = Cc["@mozilla.org/parentprocessmessagemanager;1"]
+                           .getService(Ci.nsIMessageBroadcaster);
     let messageId = ++messageCounter;
     let callback = (message) =>
     {
       let response = message.data;
       if (response.messageId != messageId)
         return;
 
-      browser.messageManager.removeMessageListener(
+      messageManager.removeMessageListener(
         "ElemHideHelper:GetNodeInfo:Response",
         callback
       );
 
       if (!response.nodeData)
         return;
 
       this.window.openDialog("chrome://elemhidehelper/content/composer.xul",
           "_blank", "chrome,centerscreen,resizable,dialog=no", response);
       this.quit();
     };
 
-    browser.messageManager.addMessageListener(
+    messageManager.addMessageListener(
       "ElemHideHelper:GetNodeInfo:Response",
       callback
     );
-    browser.messageManager.sendAsyncMessage(
+    messageManager.broadcastAsyncMessage(
       "ElemHideHelper:GetNodeInfo",
       messageId,
       {
         element: elem
       }
     );
     return false;
   },
 
   blinkElement: function(elem)
@@ skipping 165 matching lines @@
     // Show help box
     helpBox.showPopup(this.browser, -1, -1, "tooltip", "topleft", "topleft");
     return true;
   }
 }
 
 // Makes sure event handlers like Aardvark.onKeyPress always have the correct
 // this pointer set.
 for (let method of ["onMouseClick", "onMouseScroll", "onKeyPress", "onPageHide", "onMouseMove", "onAfterPaint", "quit"])
   Aardvark[method] = Aardvark[method].bind(Aardvark);