Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29332932: Issue 2269 - Update whitelisted ABP icon in Customizations extension (Closed)

Created:
Dec. 21, 2015, 3:14 p.m. by Wladimir Palant
Modified:
Dec. 23, 2015, 12:53 p.m.
Reviewers:
saroyanm
Visibility:
Public.

Description

The selectors are taken from overlay.css in ABP, merely the image URL is changed

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M chrome/content/greenToolbarIcon.css View 1 chunk +11 lines, -2 lines 3 comments Download

Messages

Total messages: 4
Wladimir Palant
Dec. 21, 2015, 3:14 p.m. (2015-12-21 15:14:17 UTC) #1
saroyanm
https://codereview.adblockplus.org/29332932/diff/29332933/chrome/content/greenToolbarIcon.css File chrome/content/greenToolbarIcon.css (right): https://codereview.adblockplus.org/29332932/diff/29332933/chrome/content/greenToolbarIcon.css#newcode33 chrome/content/greenToolbarIcon.css:33: /* 24x24 */ For ABP we only have 16x16 ...
Dec. 21, 2015, 5:03 p.m. (2015-12-21 17:03:28 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29332932/diff/29332933/chrome/content/greenToolbarIcon.css File chrome/content/greenToolbarIcon.css (right): https://codereview.adblockplus.org/29332932/diff/29332933/chrome/content/greenToolbarIcon.css#newcode33 chrome/content/greenToolbarIcon.css:33: /* 24x24 */ On 2015/12/21 17:03:28, saroyanm wrote: > ...
Dec. 21, 2015, 7:16 p.m. (2015-12-21 19:16:03 UTC) #3
saroyanm
Dec. 23, 2015, 10:58 a.m. (2015-12-23 10:58:00 UTC) #4
LGTM

https://codereview.adblockplus.org/29332932/diff/29332933/chrome/content/gree...
File chrome/content/greenToolbarIcon.css (right):

https://codereview.adblockplus.org/29332932/diff/29332933/chrome/content/gree...
chrome/content/greenToolbarIcon.css:33: /* 24x24 */
On 2015/12/21 19:16:03, Wladimir Palant wrote:
> On 2015/12/21 17:03:28, saroyanm wrote:
> > For ABP we only have 16x16 and 32x32 not sure if we need this icon.
> 
> We do have 24x24 as well (abp-status.png), it's used in SeaMonkey for example.

I see.

Powered by Google App Engine
This is Rietveld