Issue 3449 - Use sendRpcMessage instead of sendSyncMessage

lib/child/bootstrap.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 30 matching lines @@
       let index = shutdownHandlers.indexOf(handler);
       if (index >= 0)
         shutdownHandlers.splice(index, 1);
     }
   };
 
   let callbackPrefix = Services.appinfo.processID + " ";
   let maxCallbackID = 0;
   let callbacks = new Map();
 
   function sendSyncMessageSingleResponse(messageName, data)

[saroyanm, 2015/12/28 10:01:44]

nit: I think you can also change the function name.

[Wladimir Palant, 2015/12/28 13:11:03]

I don't think the name should be changed - that's an implementation detail, all
it matters is that this is still sync messaging.

   {
-    return sendSyncMessage(messageName, {data})[0];
+    return sendRpcMessage(messageName, {data})[0];
   }
 
   function sendAsyncMessageWithResponse(messageName, data, callback)
   {
     data = {data};
     if (callback)
     {
       let callbackID = callbackPrefix + (++maxCallbackID);
       callbacks.set(callbackID, callback);
       data.callbackID = callbackID;
@@ skipping 53 matching lines @@
   }
 
   sendAsyncMessageWithResponse("AdblockPlus:GetInfo", null, init);
   addMessageListener("AdblockPlus:Response", onResponse);
   addMessageListener("AdblockPlus:Shutdown", shutdown);
   onShutdown.add(() => {
     removeMessageListener("AdblockPlus:Response", onResponse);
     removeMessageListener("AdblockPlus:Shutdown", shutdown);
   });
 })();