Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(254)

Issue 29332956: Issue 3402 - Properly handle nested inline tags (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 11 months ago by kzar
Modified:
3 years, 8 months ago
CC:
saroyanm
Visibility:
Public.

Description

Issue 3402 - Properly handle nested inline tags

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M cms/converters.py View 1 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 5
kzar
Patch Set 1
3 years, 11 months ago (2015-12-22 13:52:34 UTC) #1
Sebastian Noack
I put Wladimir as reviewer since I'm on vacation.
3 years, 11 months ago (2015-12-22 15:14:18 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29332956/diff/29332957/cms/converters.py File cms/converters.py (right): https://codereview.adblockplus.org/29332956/diff/29332957/cms/converters.py#newcode185 cms/converters.py:185: for t in ("\<%s[^<>]*?\>", "\<\/%s\>") Nit: None of your ...
3 years, 10 months ago (2016-01-21 13:55:56 UTC) #3
kzar
Patch Set 2 : Addressed feedback https://codereview.adblockplus.org/29332956/diff/29332957/cms/converters.py File cms/converters.py (right): https://codereview.adblockplus.org/29332956/diff/29332957/cms/converters.py#newcode185 cms/converters.py:185: for t in ...
3 years, 9 months ago (2016-02-19 14:32:29 UTC) #4
Sebastian Noack
3 years, 8 months ago (2016-03-20 15:14:11 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5