Issue #1173 - Protect more entry points with try-catch blocks

src/plugin/PluginClass.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 992 matching lines @@
 {
   try
   {
     if (cCmds == 0) return E_INVALIDARG;
     if (prgCmds == 0) return E_POINTER;
 
     prgCmds[0].cmdf = OLECMDF_ENABLED;
   }
   catch (...)
   {
+    DEBUG_GENERAL(L"CPluginClass::QueryStatus - exception");
     return E_FAIL;
   }
   return S_OK;
 }
 
 HMENU CPluginClass::CreatePluginMenu(const std::wstring& url)
 {
   DEBUG_GENERAL("CreatePluginMenu");
   HINSTANCE hInstance = _AtlBaseModule.GetModuleInstance();
 
@@ skipping 266 matching lines @@
     }
     else
     {
       nFlags |= TPM_LEFTALIGN;
     }
 
     DisplayPluginMenu(hMenu, nIDCommand, pt, nFlags);
   }
   catch (...)
   {
-    return E_FAIL; // Suppress exceptions, should log
+    // Suppress exception, log only
+    DEBUG_GENERAL(L"CPluginClass::Exec - exception");
+    return E_FAIL;
   }
 
   return S_OK;
 }
 
 // Entry point
 LRESULT CALLBACK CPluginClass::NewStatusProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam)
 {
   CPluginClass *pClass;
   try
@@ skipping 66 matching lines @@
         return hRet;
       }
 
     default:
       break;
     }
   }
   catch (...)
   {
     // Suppress exception. Fall through to default handler.
+    DEBUG_GENERAL(L"CPluginClass::NewStatusProc - exception");
   }
   return ::CallWindowProc(pClass->m_pWndProcStatus, hWnd, message, wParam, lParam);
 }
 
 
 HICON CPluginClass::GetStatusBarIcon(const std::wstring& url)
 {
   // use the disable icon as defualt, if the client doesn't exists
   HICON hIcon = GetIcon(ICON_PLUGIN_DEACTIVATED);
 
@@ skipping 216 matching lines @@
         std::wstring downloadingText = dictionary->Lookup("updater", "downloading-update-text");
         std::wstring downloadingTitle = dictionary->Lookup("updater", "downloading-update-title");
         pClass->notificationMessage.SetTextAndIcon(downloadingText, downloadingTitle, TTI_INFO);
         break;
       }
     }
   }
   catch (...)
   {
     // Suppress exception. Fall through to default handler.
+    DEBUG_GENERAL(L"CPluginClass::PaneWindowProc - exception");
   }
   return ::DefWindowProc(hWnd, message, wParam, lParam);
 }
 
 
 void CPluginClass::UpdateStatusBar()
 {
   DEBUG_GENERAL("*** Updating statusbar")
   if (m_hPaneWnd == NULL)
   {
@@ skipping 50 matching lines @@
   s_criticalSectionLocal.Unlock();
 
   return icon;
 }
 
 ATOM CPluginClass::GetAtomPaneClass()
 {
   return s_atomPaneClass;
 }