Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(368)

Issue 29333043: Issue 3452 - Bring back $ping type option (Core changes) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by Wladimir Palant
Modified:
4 years, 3 months ago
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 3452 - Bring back $ping type option (Core changes)

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M chrome/locale/en-US/global.properties View 1 chunk +1 line, -0 lines 0 comments Download
M lib/contentPolicy.js View 2 chunks +8 lines, -3 lines 3 comments Download
M lib/filterClasses.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Wladimir Palant
4 years, 3 months ago (2015-12-23 13:04:50 UTC) #1
Sebastian Noack
LGTM, with or without the comment addressed. https://codereview.adblockplus.org/29333043/diff/29333044/lib/contentPolicy.js File lib/contentPolicy.js (right): https://codereview.adblockplus.org/29333043/diff/29333044/lib/contentPolicy.js#newcode129 lib/contentPolicy.js:129: // same ...
4 years, 3 months ago (2015-12-23 13:34:45 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29333043/diff/29333044/lib/contentPolicy.js File lib/contentPolicy.js (right): https://codereview.adblockplus.org/29333043/diff/29333044/lib/contentPolicy.js#newcode129 lib/contentPolicy.js:129: // same concept - merely generalized. On 2015/12/23 13:34:45, ...
4 years, 3 months ago (2015-12-23 14:14:34 UTC) #3
Sebastian Noack
4 years, 3 months ago (2015-12-23 14:18:19 UTC) #4
Message was sent while issue was closed.
https://codereview.adblockplus.org/29333043/diff/29333044/lib/contentPolicy.js
File lib/contentPolicy.js (right):

https://codereview.adblockplus.org/29333043/diff/29333044/lib/contentPolicy.j...
lib/contentPolicy.js:129: // same concept - merely generalized.
On 2015/12/23 14:14:34, Wladimir Palant wrote:
> On 2015/12/23 13:34:45, Sebastian Noack wrote:
> > I'm inclined to also add a note that we cannot distinguis BEACON and PING on
> > Chrome anyway.
> 
> That means fairly little for Firefox - we wouldn't dumb down our Firefox
> extension because of Chrome if distinguishing the types made sense.

Well, given that Chrome is our largest platform, I think the feasibility of
implementing a filter there, should be something we should consider, when adding
new filters.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5