Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29333123: Issue 3459 - Make content policy test for fetch() explicitly dispatch abp:frameready (Closed)

Created:
Dec. 30, 2015, 3:40 p.m. by Sebastian Noack
Modified:
Jan. 1, 2016, 2:47 p.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 3459 - Make content policy test for fetch() explicitly dispatch abp:frameready

Patch Set 1 #

Total comments: 2

Patch Set 2 : Set explicitEvent #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M chrome/content/tests/policy.js View 1 2 chunks +14 lines, -3 lines 1 comment Download

Messages

Total messages: 4
Sebastian Noack
Dec. 30, 2015, 3:42 p.m. (2015-12-30 15:42:19 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/29333123/diff/29333124/chrome/content/tests/policy.js File chrome/content/tests/policy.js (right): https://codereview.adblockplus.org/29333123/diff/29333124/chrome/content/tests/policy.js#newcode309 chrome/content/tests/policy.js:309: "http://127.0.0.1:1234/test.xml", "xmlhttprequest", false, false Last value should be true ...
Dec. 31, 2015, 1:38 p.m. (2015-12-31 13:38:46 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29333123/diff/29333124/chrome/content/tests/policy.js File chrome/content/tests/policy.js (right): https://codereview.adblockplus.org/29333123/diff/29333124/chrome/content/tests/policy.js#newcode309 chrome/content/tests/policy.js:309: "http://127.0.0.1:1234/test.xml", "xmlhttprequest", false, false On 2015/12/31 13:38:45, Wladimir Palant ...
Dec. 31, 2015, 2:36 p.m. (2015-12-31 14:36:39 UTC) #3
Wladimir Palant
Dec. 31, 2015, 6:52 p.m. (2015-12-31 18:52:10 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld