Issue 3459 - Make content policy test for fetch() explicitly dispatch abp:frameready

chrome/content/tests/policy.js

 (function()
 {
   let server = null;
   let frame = null;
   let requestNotifier = null;
   let httpProtocol = null;
 
   module("Content policy", {
     setup: function()
     {
@@ skipping 288 matching lines @@
           'function()' +
           '{' +
             dispatchReadyEvent +
           '},' +
           'function()' +
           '{' +
             dispatchReadyEvent +
           '}' +
         ');' +
       '</script>',
-      "http://127.0.0.1:1234/test.xml", "xmlhttprequest", false, false

[Wladimir Palant, 2015/12/31 13:38:45]

Last value should be true here, not false (explicitEvent).

[Sebastian Noack, 2015/12/31 14:36:39]

Done.

+      "http://127.0.0.1:1234/test.xml", "xmlhttprequest", false, true
     ]);
   }
 
   let policyHits = [];
   function onPolicyHit(item, scanComplete)
   {
     if (!item)
       return;
     if (item.location == "http://127.0.0.1:1234/test" ||
         item.location == "http://127.0.0.1:1234/redirect.gif" ||
@@ skipping 138 matching lines @@
     3: "running with filter %S and site exception",
     4: "running with filter %S and exception not applicable to sites",
     5: "running with filter %S and sitekey exception",
     6: "running with filter %S and $genericblock exception",
     7: "running with filter %S$domain=127.0.0.1 and $genericblock exception",
     8: "running with filter %S and $genericblock,sitekey exception"
   };
 
   for (let test = 0; test < tests.length; test++)
   {
-    let [name, body, expectedURL, expectedType, expectedDomain, expectedThirdParty] = tests[test];
+    let [name, , expectedURL] = tests[test];

[Sebastian Noack, 2015/12/31 14:36:39]

I were already wondering whether the last parameter indicates async tests.
However, this line, wrongly unpacking the array, tricked me.

     for (let stage = 1; stage in stageDescriptions; stage++)
     {
       let stageDescription = stageDescriptions[stage];
       if (stageDescription.indexOf("%S") >= 0)
         stageDescription = stageDescription.replace("%S", expectedURL);
 
       asyncTest(name + " (" + stageDescription + ")", runTest.bind(null, tests[test], stage));
     }
   }
 })();