Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29333128: Issue 3463 - Filtering broken in Diagnostics (Closed)

Created:
Jan. 4, 2016, 2:22 p.m. by Wladimir Palant
Modified:
Jan. 7, 2016, 9:09 p.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Little known fact: for each..in loops will iterate over object values, for..of naturally won`t.

Patch Set 1 #

Patch Set 2 : Don`t use non-standard Iterator constructor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/content/watcher.js View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
Wladimir Palant
Jan. 4, 2016, 2:22 p.m. (2016-01-04 14:22:31 UTC) #1
Thomas Greiner
Jan. 4, 2016, 2:32 p.m. (2016-01-04 14:32:37 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld