Issue 3259 - Store blockable items selection in the content process

chrome/content/ui/sidebar.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 71 matching lines @@
     let defaults = {screenX: 0, screenY: 0, width: 600, height: 300};
     if (params && params.position)
       defaults = params.position;
 
     let wnd = parent.document.documentElement;
     for (let attr in defaults)
       if (!wnd.hasAttribute(attr))
         wnd.setAttribute(attr, defaults[attr]);
   }
 
-  let {getBrowser, addBrowserLocationListener} = require("appSupport");
+  let {addBrowserLocationListener} = require("appSupport");
   updateContentLocation();
-  Object.defineProperty(window, "content", { get: () => getBrowser(mainWin).contentWindow });
 
   // Initialize matcher for disabled filters
   reloadDisabledFilters();
   FilterNotifier.addListener(reloadDisabledFilters);
   Prefs.addListener(onPrefChange);
 
   // Activate flasher
   list.addEventListener("select", onSelectionChange, false);
 
   // Initialize data
@@ skipping 14 matching lines @@
 
 function updateContentLocation()
 {
   let {getCurrentLocation} = require("appSupport");
   let location = getCurrentLocation(mainWin);
   if (location instanceof Ci.nsIURI)
     location = location.spec;
   contentLocation = location;
 }
 
+function getOuterWindowID()
+{
+  let {getBrowser} = require("appSupport");
+  let browser = getBrowser(mainWin);
+  if ("selectedBrowser" in browser)
+    browser = browser.selectedBrowser;
+  return browser.outerWindowID;
+}
+
 function getFilter(item)
 {
   if ("filter" in item && item.filter)
     return Filter.fromText(item.filter);
   else
     return null;
 }
 
 // To be called on unload
 function cleanUp() {
@@ skipping 56 matching lines @@
 }
 
 // Called whenever list selection changes - triggers flasher
 function onSelectionChange() {
   var item = treeView.getSelectedItem();
   if (item)
     E("copy-command").removeAttribute("disabled");
   else
     E("copy-command").setAttribute("disabled", "true");
 
-  if (item && window.content)
+  if (item)
   {
     let key = item.location + " " + item.type + " " + item.docDomain;
-    RequestNotifier.storeSelection(window.content, key);
+    RequestNotifier.storeWindowData(getOuterWindowID(), key);
     treeView.itemToSelect = null;
   }
 
   if (requestNotifier)
     requestNotifier.flashNodes(item ? item.ids : null, Prefs.flash_scrolltoitem);
 }
 
 function handleLocationChange()
 {
   if (requestNotifier)
     requestNotifier.shutdown();
 
   updateContentLocation();
   treeView.clearData();
 
-  let {getBrowser, addBrowserLocationListener} = require("appSupport");
-  let browser = getBrowser(mainWin);
-  if ("selectedBrowser" in browser)
-    browser = browser.selectedBrowser;
-  let outerWindowID = browser.outerWindowID;
-  if (window.content)
-    treeView.itemToSelect = RequestNotifier.getSelection(window.content);
-  requestNotifier = new RequestNotifier(outerWindowID, function(item, scanComplete)
+  let outerWindowID = getOuterWindowID();
+  RequestNotifier.retrieveWindowData(outerWindowID, key =>
+  {
+    treeView.itemToSelect = key;
+  });
+  requestNotifier = new RequestNotifier(outerWindowID, (item, scanComplete) =>
   {
     if (item)
       treeView.addItem(item, scanComplete);
   });
   cacheStorage = null;
 }
 
 // Fills a box with text splitting it up into multiple lines if necessary
 function setMultilineContent(box, text, noRemove)
 {
@@ skipping 1088 matching lines @@
       return {tooltip: this.itemsDummyTooltip};
   },
 
   invalidateItem: function(item)
   {
     let row = this.data.indexOf(item);
     if (row >= 0)
       this.boxObject.invalidateRow(row);
   }
 }