Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: modules/adblockplus/manifests/log/master.pp

Issue 29333248: Issue 3306 - Create uplinks for pushing log files (Closed)
Left Patch Set: Created Jan. 6, 2016, 12:09 p.m.
Right Patch Set: Issue 3306 - Address feedback from code-review Created Jan. 14, 2016, 3:05 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « modules/adblockplus/manifests/log.pp ('k') | modules/adblockplus/manifests/log/uplink.pp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 # == Class: adblockplus::log::master 1 # == Class: adblockplus::log::master
2 # 2 #
3 # A server setup to collect and pre-process (i.e. anonymize and combine) 3 # A server setup to collect and pre-process (i.e. anonymize and combine)
4 # log files using Logstash (https://logstash.net/) pipelines. 4 # log files using Logstash (https://logstash.net/) pipelines.
5 # 5 #
6 # === Parameters: 6 # === Parameters:
7 # 7 #
8 # [*uplinks*] 8 # [*uplinks*]
9 # A hash of $name => $parameters resembling the servers registry within 9 # A hash of $name => $parameters resembling the servers registry within
10 # file modules/private/hiera/hosts.yaml, which is used by default. 10 # file modules/private/hiera/hosts.yaml, which is used by default.
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 owner => 'root', 63 owner => 'root',
64 require => [ 64 require => [
65 File[$adblockplus::log::directory], 65 File[$adblockplus::log::directory],
66 Package['logstash'], 66 Package['logstash'],
67 ], 67 ],
68 } 68 }
69 69
70 # The Python script dispatching incoming logs 70 # The Python script dispatching incoming logs
71 file {$import_script: 71 file {$import_script:
72 ensure => 'present', 72 ensure => 'present',
73 group => $adblockplus::log::user,
Fred 2016/01/07 15:19:16 Shouldn't this be $adblockplus::log::group?
mathias 2016/01/14 15:03:52 Actually it's obsolete. A fragment from an earlier
74 mode => 0755, 73 mode => 0755,
75 require => User[$adblockplus::log::user], 74 require => User[$adblockplus::log::user],
76 source => 'puppet:///modules/adblockplus/log/import.py', 75 source => 'puppet:///modules/adblockplus/log/import.py',
77 } 76 }
78 77
79 # See modules/adblockplus/manifests/log/uplink.pp 78 # See modules/adblockplus/manifests/log/uplink.pp
80 create_resources('adblockplus::log::uplink', $uplinks) 79 create_resources('adblockplus::log::uplink', $uplinks)
81 } 80 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld