Issue 2359 - Fixed styles of list items in options page

This review contains the following minor changes:
- fixed: dialog doesn't scroll
- fixed: dialog background doesn't overlay entire page
- fixed: long dialog title overflows
- fixed: long filter list title overflows
- fixed: language dialog list doesn't scroll
- removed WebKit-specific custom scrollbar styles
- corrected height of tables in language selection dialog
- corrected height of table items
- added border radius to table items

[saroyanm, 2016-01-25 16:32:37]

https://codereview.adblockplus.org/29333262/diff/29333273/skin/options.css
File skin/options.css (right):

https://codereview.adblockplus.org/29333262/diff/29333273/skin/options.css#ne...
skin/options.css:349: white-space: nowrap;
What about setup max-width as well, because currently the long texts are making
the list items to shrink. 
Maybe 300px ?

https://codereview.adblockplus.org/29333262/diff/29333273/skin/options.css#ne...
skin/options.css:948: position: fixed;
Note: I think whenever we fixing a block we can also make it consistent with
coding-standards we have. 
Anyway feel free to keep as it is, It's just a note that we can keep in mind in
future working on the CSS part.

https://codereview.adblockplus.org/29333262/diff/29333273/skin/options.css#ne...
skin/options.css:1073: display: flex;
For some reason, RTL have a bug. It feels like caused by flex, but not really
sure.
When I go to "Add other language dialog" click on Add button I see an offset of
the UL element that contains the languages list.

[saroyanm, 2016-01-25 17:16:17]

https://codereview.adblockplus.org/29333262/diff/29333273/skin/options.css
File skin/options.css (right):

https://codereview.adblockplus.org/29333262/diff/29333273/skin/options.css#ne...
skin/options.css:1073: display: flex;
On 2016/01/25 16:32:37, saroyanm wrote:
> For some reason, RTL have a bug. It feels like caused by flex, but not really
> sure.
> When I go to "Add other language dialog" click on Add button I see an offset
of
> the UL element that contains the languages list.

Browser update, fixed the issue.

[Thomas Greiner, 2016-01-25 18:41:24]

https://codereview.adblockplus.org/29333262/diff/29333273/skin/options.css
File skin/options.css (right):

https://codereview.adblockplus.org/29333262/diff/29333273/skin/options.css#ne...
skin/options.css:349: white-space: nowrap;
On 2016/01/25 16:32:37, saroyanm wrote:
> What about setup max-width as well, because currently the long texts are
making
> the list items to shrink. 
> Maybe 300px ?

You're right. That behavior must've been introduced by one of the other changes
in this review because it worked as expected when I implemented it.

The style guide defines a "400px" width for each of the quadrants so I went with
that. Note that we don't need to set `flex: 1` since the width doesn't change
anyway.

https://codereview.adblockplus.org/29333262/diff/29333273/skin/options.css#ne...
skin/options.css:948: position: fixed;
On 2016/01/25 16:32:37, saroyanm wrote:
> Note: I think whenever we fixing a block we can also make it consistent with
> coding-standards we have. 
> Anyway feel free to keep as it is, It's just a note that we can keep in mind
in
> future working on the CSS part.

Done.

[saroyanm, 2016-01-26 18:41:51]

LGTM