Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(254)

Issue 29333265: Issue 3478 - Hide genericblock and generichide from the composer (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years ago by Sebastian Noack
Modified:
4 years ago
CC:
kzar
Visibility:
Public.

Description

Issue 3478 - Hide genericblock and generichide from the composer

Patch Set 1 #

Total comments: 4

Patch Set 2 : Hide (instead disable) generichide and genericblock #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/content/ui/composer.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8
Sebastian Noack
4 years ago (2016-01-06 15:35:02 UTC) #1
Wladimir Palant
LGTM
4 years ago (2016-01-06 15:36:45 UTC) #2
Thomas Greiner
https://codereview.adblockplus.org/29333265/diff/29333266/chrome/content/ui/composer.js File chrome/content/ui/composer.js (right): https://codereview.adblockplus.org/29333265/diff/29333266/chrome/content/ui/composer.js#newcode227 chrome/content/ui/composer.js:227: if (value == "document" || value == "genericblock" || ...
4 years ago (2016-01-06 15:44:51 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29333265/diff/29333266/chrome/content/ui/composer.js File chrome/content/ui/composer.js (right): https://codereview.adblockplus.org/29333265/diff/29333266/chrome/content/ui/composer.js#newcode227 chrome/content/ui/composer.js:227: if (value == "document" || value == "genericblock" || ...
4 years ago (2016-01-06 15:49:33 UTC) #4
Thomas Greiner
https://codereview.adblockplus.org/29333265/diff/29333266/chrome/content/ui/composer.js File chrome/content/ui/composer.js (right): https://codereview.adblockplus.org/29333265/diff/29333266/chrome/content/ui/composer.js#newcode227 chrome/content/ui/composer.js:227: if (value == "document" || value == "genericblock" || ...
4 years ago (2016-01-06 16:07:02 UTC) #5
Sebastian Noack
https://codereview.adblockplus.org/29333265/diff/29333266/chrome/content/ui/composer.js File chrome/content/ui/composer.js (right): https://codereview.adblockplus.org/29333265/diff/29333266/chrome/content/ui/composer.js#newcode227 chrome/content/ui/composer.js:227: if (value == "document" || value == "genericblock" || ...
4 years ago (2016-01-06 16:15:11 UTC) #6
Thomas Greiner
LGTM
4 years ago (2016-01-06 16:49:21 UTC) #7
Wladimir Palant
4 years ago (2016-01-07 13:41:56 UTC) #8
Message was sent while issue was closed.
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5